Skip to content

vl.c: Error message rework

Eduardo Habkost qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 5 repliesIn review
  2. v216 patches 9 repliesSuperseded
  3. v11 patch 13 repliesSuperseded

Changes in v3 from the cover letter

* Removed patch: "vl.c: Convert error sentences to simpler phrases"
* Removed patch: "vl.c: Reword -machine help error messages"
* Removed patch: "vl.c: Reword fw_cfg name prefix warning"
* Removed patch: "vl.c: Use US spelling for 'unrecognized'"
* New patch: "vl.c: Change 'fail to parse' error message to 'failed to parse'"
* Squashed "vl.c: trivial: Don't wrap lines unnecessarily"
into "vl.c: Replace fprintf(stderr) with error_report()"

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11vl.c: Replace fprintf(stderr) with error_report()vl.c+115 -1160 replies
2/11vl.c: Use error_report() when reporting shutdown signalvl.c+3 -30 replies
3/11vl.c: Remove periods and exclamation points from error messagesvl.c+15 -150 replies
4/11vl.c: Use "warning:" prefix consistently on warningsvl.c+4 -40 replies
5/11vl.c: Use "cannot" instead of "can not" in error messagesvl.c+2 -20 replies
6/11vl.c: Use 'quotes' instead of `quotes' in messagesvl.c+2 -20 replies
7/11vl.c: Remove unnecessary uppercase in error messagesvl.c+19 -210 replies
8/11vl.c: Change "fail to parse" error message to "failed to parse"vl.c+1 -10 replies
9/11vl.c: Simplify "ignoring deprecated option" warningsvl.c+2 -40 replies
10/11vl.c: Reword -no-kvm-pit-reinjection deprecation warningvl.c+2 -20 replies
11/11vl.c: Use "%s support is disabled" error messages consistentlyvl.c+5 -60 replies

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by.

PatchMarkus Armbruster
1/11
2/11R-b
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 00/11] vl.c: Error message rework

Changes v2 -> v3:
* Removed patch: "vl.c: Convert error sentences to simpler phrases"
* Removed patch: "vl.c: Reword -machine help error messages"
* Removed patch: "vl.c: Reword fw_cfg name prefix warning"
* Removed patch: "vl.c: Use US spelling for 'unrecognized'"
* New patch: "vl.c: Change 'fail to parse' error message to 'failed to parse'"
* Squashed "vl.c: trivial: Don't wrap lines unnecessarily"
into "vl.c: Replace fprintf(stderr) with error_report()"

Changes v1 -> v2:
* Extra patches for many suggestions I got when changing vl.c to use error_report()

Eduardo Habkost (11):
vl.c: Replace fprintf(stderr) with error_report() vl.c: Use error_report() when reporting shutdown signal vl.c: Remove periods and exclamation points from error messages vl.c: Use "warning:" prefix consistently on warnings vl.c: Use "cannot" instead of "can not" in error messages vl.c: Use 'quotes' instead of `quotes' in messages vl.c: Remove unnecessary uppercase in error messages vl.c: Change "fail to parse" error message to "failed to parse" vl.c: Simplify "ignoring deprecated option" warnings vl.c: Reword -no-kvm-pit-reinjection deprecation warning vl.c: Use "%s support is disabled" error messages consistently

 vl.c | 256 +++++++++++++++++++++++++++++++++----------------------------------
 1 file changed, 125 insertions(+), 131 deletions(-)
Signature · 1 line
2.1.0