Skip to content

qemu-io: clean up cvtnum usage

John Snow qemu-devel 4 versions – Applied

Status from this message: Thanks, applied to the block branch. (Should we mention in the changelog

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 2 repliesApplied
  2. v33 patches 1 replySuperseded
  3. v23 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches6 repliesSuperseded

Changes in v4 from the cover letter

- Now missing ALL sweaters

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3qemu-io: fix cvtnum lval typesqemu-io-cmds.c+87 -360 replies
2/3qemu-io: Check for trailing charsqemu-io-cmds.c+8 -10 replies
3/3qemu-io: Correct error messagesqemu-io-cmds.c+34 -190 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchEric BlakeKevin Wolf
1/3
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/3] qemu-io: clean up cvtnum usage

cvtnum returns an int64_t, not an int, so correct the lvalue types wherever it is used. While we're at it, make the error messages more meaningful and hopefully less confusing.

v4:
- Now missing ALL sweaters

v3:
- pulled a lot of loose yarn, now missing my sweater (Updated patch 1 even further, reported-by Kevin)

v2:
- Squashed NSIG error-checking from patch 3 into patch 1
- Reported-by credits for Max and Reviewed-by from Eric added

________________________________________________________________________________

For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch qemu-io-tidy
https://github.com/jnsnow/qemu/tree/qemu-io-tidy

This version is tagged qemu-io-tidy-v4:
https://github.com/jnsnow/qemu/releases/tag/qemu-io-tidy-v4

John Snow (3):
qemu-io: fix cvtnum lval types
qemu-io: Check for trailing chars
qemu-io: Correct error messages

 qemu-io-cmds.c | 185 ++++++++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 129 insertions(+), 56 deletions(-)
Signature · 1 line
2.4.3