Skip to content

ethdev: force deprecation of statistics

Stephen Hemminger dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest7 patches 4 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ether: don't mark input multicast for deprecationdrivers/net/ixgbe/ixgbe_ethdev.c lib/librte_ether/rte_ethdev.h+1 -32 replies
2/7bond: don't sum deprecated statisticsdrivers/net/bonding/rte_eth_bond_pmd.c+1 -60 replies
3/7cxgbe: don't report deprecated statisticsdrivers/net/cxgbe/cxgbe_ethdev.c+3 -70 replies
4/7i40e: don't report deprecated statisticsdrivers/net/i40e/i40e_ethdev.c+4 -50 replies
5/7e1000: don't report deprecated statisticsdrivers/net/e1000/em_ethdev.c drivers/net/e1000/igb_ethdev.c+4 -200 replies
6/7test-pmd: remove references to deprecated statisticsapp/test-pmd/config.c app/test-pmd/testpmd.c app/test/test_pmd_perf.c+6 -490 replies
7/7rte_ether: mark deprecated statistics with attributelib/librte_eal/common/include/rte_common.h lib/librte_ether/rte_ethdev.h+11 -81 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] ethdev: force deprecation of statistics

Several fields in ether statistics were tagged with comment that they were going to be deprecated, but comments don't cause compile warnings. Instead use Gcc attributes to force the issue.

Of course to do that, all the drivers and tests which are using those fields have to be fixed first.

The input multicast statistic was listed as deprecated, but I find it useful, and therefore the first patch is to revive it.

Stephen Hemminger (7):
ether: don't mark input multicast for deprecation
bond: don't sum deprecated statistics
cxgbe: don't report deprecated statistics
i40e: don't report deprecated statistics
e1000: don't report deprecated statistics
test-pmd: remove references to deprecated statistics
rte_ether: mark deprecated statistics with attribute

 app/test-pmd/config.c                      | 22 ++--------------------
 app/test-pmd/testpmd.c                     | 26 ++------------------------
 app/test/test_pmd_perf.c                   |  7 ++-----
 drivers/net/bonding/rte_eth_bond_pmd.c     |  7 +------
 drivers/net/cxgbe/cxgbe_ethdev.c           | 10 +++-------
 drivers/net/e1000/em_ethdev.c              | 12 ++----------
 drivers/net/e1000/igb_ethdev.c             | 12 ++----------
 drivers/net/i40e/i40e_ethdev.c             |  9 ++++-----
 drivers/net/ixgbe/ixgbe_ethdev.c           |  1 -
 lib/librte_eal/common/include/rte_common.h |  3 +++
 lib/librte_ether/rte_ethdev.h              | 19 +++++++++----------
 11 files changed, 30 insertions(+), 98 deletions(-)
Signature · 1 line
2.1.4