Skip to content

Improving rpc.gssd's debugging

Steve Dickson linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3gssd: reworked first level of debuggingutils/gssd/gssd_proc.c utils/gssd/krb5_util.c+19 -210 replies
2/3gssd: log all fatal errorsutils/gssd/gssd.c utils/gssd/gssd_proc.c utils/gssd/krb5_util.c+8 -80 replies
3/3gssd: reworked second level of debuggingutils/gssd/context_heimdal.c utils/gssd/context_lucid.c utils/gssd/gssd.c +2 more+13 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Improving rpc.gssd's debugging

Now that rpc.gssd is the critical path of every NFS mount, any favored mount, I thought I would take a crack at making the daemon a bit more debuggable by making the logging more readable.

The first level of debugging (-v) will only log errors and warnings that are not normally logged. I'm thinking this might be a good level to run at a customer's site.

I also thought about changing the majority of the printerr(0) which always log to printerr(1)s. I decided not to since I figured more info is better.

Note, I didn't remove any of the messages, I just pushed them back to other debug levels.

I trimmed down the second level of debugging (-vv) by again moving them back to other levels.

The third level (-vvv) is basically the same.

Using the fourth level (-vvvv) to enable all the logging that old level three did.

Thoughts/Comments... A waste of a good Saturday afternoon?? ;-)

Steve Dickson (3):
gssd: reworked first level of debugging
gssd: log all fatal errors
gssd: reworked second level of debugging

 utils/gssd/context_heimdal.c |  2 +-
 utils/gssd/context_lucid.c   |  6 +++---
 utils/gssd/gssd.c            | 14 +++++++-------
 utils/gssd/gssd_proc.c       | 32 +++++++++++++-------------------
 utils/gssd/krb5_util.c       | 28 ++++++++++++++++------------
 5 files changed, 40 insertions(+), 42 deletions(-)
Signature · 1 line
2.4.3