tty core printk cleanup
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest14 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | tty: Improve tty_debug() macroinclude/ | +2 | 3 replies | |
| 2/14 | tty: Make tty_paranoia_check() file scopedrivers/ include/ | +1 | 0 replies | |
| 3/14 | tty: synclink_gt: Rename tty_driver_namedrivers/ | +2 | 0 replies | |
| 4/14 | tty: core: Remove redundant oom messagedrivers/ | +1 | 0 replies | |
| 5/14 | tty: core: Add helper fn to deref tty driver namedrivers/ include/ | +8 | 0 replies | |
| 6/14 | tty: Define tty_*() printk macrosdrivers/ drivers/ drivers/ +1 more | +27 | 0 replies | |
| 7/14 | tty: Convert SAK messages to tty_notice()drivers/ | +8 | 0 replies | |
| 8/14 | tty: core: Add driver name to invalid device registration messagedrivers/ | +2 | 0 replies | |
| 9/14 | tty: core: Refactor parameters for unset_locked_termios() helperdrivers/ | +4 | 0 replies | |
| 10/14 | tty: Remove unset_locked_termios() error messagedrivers/ | +0 | 0 replies | |
| 11/14 | tty: core: Prefer pr_* to printk(*)drivers/ drivers/ | +4 | 0 replies | |
| 12/14 | tty: Remove __func__ from tty_debug() macrodrivers/ drivers/ drivers/ +1 more | +10 | 0 replies | |
| 13/14 | tty: Merge conditional + error message + WARN_ON()drivers/ | +2 | 0 replies | |
| 14/14 | tty: core: Prefer dev_dbg() over pr_debug()drivers/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/14] tty core printk cleanup
Hi Greg,
As you requested [1], I re-worked the tty_debug() macro to format printk output like dev_dbg(), ie., <driver> <tty name>: <fmt>. At the same time, I rolled in Joe's original suggestions [2].
This series also removes the __func__ from tty_debug() since it's redundant when dynamic_debug is enabled (I edited the messages to provide enough context if dynamic_debug is not enabled).
The remainder of this series adds tty_*() printk macros (like netdev_*()) and cleans up printk() usage in the tty core.
[1] http://www.gossamer-threads.com/lists/linux/kernel/2232363#2232363
[2] http://www.gossamer-threads.com/lists/linux/kernel/2213266#2213266
Regards,
Peter Hurley (14):
tty: Improve tty_debug() macro
tty: Make tty_paranoia_check() file scope
tty: synclink_gt: Rename tty_driver_name
tty: core: Remove redundant oom message
tty: core: Add helper fn to deref tty driver name
tty: Define tty_*() printk macros
tty: Convert SAK messages to tty_notice()
tty: core: Add driver name to invalid device registration message
tty: core: Refactor parameters for unset_locked_termios() helper
tty: Remove unset_locked_termios() error message
tty: core: Prefer pr_* to printk(*)
tty: Remove __func__ from tty_debug() macro
tty: Merge conditional + error message + WARN_ON()
tty: core: Prefer dev_dbg() over pr_debug()
drivers/tty/n_tty.c | 7 ++-- drivers/tty/pty.c | 2 +- drivers/tty/synclink_gt.c | 4 +-- drivers/tty/tty_io.c | 86 +++++++++++++++++++++-------------------------- drivers/tty/tty_ioctl.c | 21 ++++-------- drivers/tty/tty_mutex.c | 10 ++---- drivers/tty/tty_port.c | 9 +++-- include/linux/tty.h | 19 +++++++---- 8 files changed, 69 insertions(+), 89 deletions(-)
Signature · 1 line
2.6.3