Skip to content

tty core printk cleanup

Peter Hurley lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14tty: Improve tty_debug() macroinclude/linux/tty.h+2 -53 replies
2/14tty: Make tty_paranoia_check() file scopedrivers/tty/tty_io.c include/linux/tty.h+1 -30 replies
3/14tty: synclink_gt: Rename tty_driver_namedrivers/tty/synclink_gt.c+2 -20 replies
4/14tty: core: Remove redundant oom messagedrivers/tty/tty_io.c+1 -30 replies
5/14tty: core: Add helper fn to deref tty driver namedrivers/tty/tty_io.c include/linux/tty.h+8 -00 replies
6/14tty: Define tty_*() printk macrosdrivers/tty/n_tty.c drivers/tty/tty_io.c drivers/tty/tty_port.c +1 more+27 -280 replies
7/14tty: Convert SAK messages to tty_notice()drivers/tty/tty_io.c+8 -120 replies
8/14tty: core: Add driver name to invalid device registration messagedrivers/tty/tty_io.c+2 -20 replies
9/14tty: core: Refactor parameters for unset_locked_termios() helperdrivers/tty/tty_ioctl.c+4 -40 replies
10/14tty: Remove unset_locked_termios() error messagedrivers/tty/tty_ioctl.c+0 -50 replies
11/14tty: core: Prefer pr_* to printk(*)drivers/tty/tty_io.c drivers/tty/tty_ioctl.c+4 -80 replies
12/14tty: Remove __func__ from tty_debug() macrodrivers/tty/pty.c drivers/tty/tty_io.c drivers/tty/tty_ioctl.c +1 more+10 -110 replies
13/14tty: Merge conditional + error message + WARN_ON()drivers/tty/tty_mutex.c+2 -80 replies
14/14tty: core: Prefer dev_dbg() over pr_debug()drivers/tty/tty_io.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/14] tty core printk cleanup

Hi Greg,

As you requested [1], I re-worked the tty_debug() macro to format printk output like dev_dbg(), ie., <driver> <tty name>: <fmt>. At the same time, I rolled in Joe's original suggestions [2].

This series also removes the __func__ from tty_debug() since it's redundant when dynamic_debug is enabled (I edited the messages to provide enough context if dynamic_debug is not enabled).

The remainder of this series adds tty_*() printk macros (like netdev_*()) and cleans up printk() usage in the tty core.

[1] http://www.gossamer-threads.com/lists/linux/kernel/2232363#2232363
[2] http://www.gossamer-threads.com/lists/linux/kernel/2213266#2213266

Regards,

Peter Hurley (14):
tty: Improve tty_debug() macro
tty: Make tty_paranoia_check() file scope
tty: synclink_gt: Rename tty_driver_name
tty: core: Remove redundant oom message
tty: core: Add helper fn to deref tty driver name
tty: Define tty_*() printk macros
tty: Convert SAK messages to tty_notice()
tty: core: Add driver name to invalid device registration message
tty: core: Refactor parameters for unset_locked_termios() helper
tty: Remove unset_locked_termios() error message
tty: core: Prefer pr_* to printk(*)
tty: Remove __func__ from tty_debug() macro
tty: Merge conditional + error message + WARN_ON()
tty: core: Prefer dev_dbg() over pr_debug()

 drivers/tty/n_tty.c       |  7 ++--
 drivers/tty/pty.c         |  2 +-
 drivers/tty/synclink_gt.c |  4 +--
 drivers/tty/tty_io.c      | 86 +++++++++++++++++++++--------------------------
 drivers/tty/tty_ioctl.c   | 21 ++++--------
 drivers/tty/tty_mutex.c   | 10 ++----
 drivers/tty/tty_port.c    |  9 +++--
 include/linux/tty.h       | 19 +++++++----
 8 files changed, 69 insertions(+), 89 deletions(-)
Signature · 1 line
2.6.3