Skip to content

ALUA device handler update, part 1

Hannes Reinecke linux-scsi 2 versions – Applied

Status from this message: Applied to 4.5/scsi-queue.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest18 patches 11 repliesApplied
  2. v118 patches 29 repliesSuperseded

Changes to v1 from the cover letter

- Update to 4.5/scsi-queue
- Rename 'device_id' to 'wwid'

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/18scsi_dh: move 'dh_state' sysfs attribute to generic codedrivers/scsi/scsi_dh.c drivers/scsi/scsi_priv.h drivers/scsi/scsi_sysfs.c+60 -730 replies
2/18scsi: ignore errors from scsi_dh_add_device()drivers/scsi/scsi_sysfs.c+4 -30 replies
3/18scsi_dh_alua: Disable ALUA handling for non-disk devicesdrivers/scsi/device_handler/scsi_dh_alua.c+12 -01 reply
4/18scsi_dh_alua: Use vpd_pg83 informationdrivers/scsi/device_handler/scsi_dh_alua.c+18 -691 reply
5/18scsi_dh_alua: improved loggingdrivers/scsi/device_handler/scsi_dh_alua.c+8 -21 reply
6/18scsi_dh_alua: sanitze sense code handlingdrivers/scsi/device_handler/scsi_dh_alua.c+7 -110 replies
7/18scsi_dh_alua: use standard logging functionsdrivers/scsi/device_handler/scsi_dh_alua.c+13 -140 replies
8/18scsi_dh_alua: return standard SCSI return codes in submit_rtpgdrivers/scsi/device_handler/scsi_dh_alua.c+17 -161 reply
9/18scsi_dh_alua: fixup description of stpg_endio()drivers/scsi/device_handler/scsi_dh_alua.c+2 -41 reply
10/18scsi: remove scsi_show_sense_hdr()include/scsi/scsi_dbg.h+0 -21 reply
11/18scsi_dh_alua: use flag for RTPG extended headerdrivers/scsi/device_handler/scsi_dh_alua.c+7 -81 reply
12/18scsi_dh_alua: use unaligned access macrosdrivers/scsi/device_handler/scsi_dh_alua.c+8 -151 reply
13/18scsi_dh_alua: rework alua_check_tpgs() to return the tpgs modedrivers/scsi/device_handler/scsi_dh_alua.c+11 -140 replies
14/18scsi_dh_alua: simplify sense code handlingdrivers/scsi/device_handler/scsi_dh_alua.c+17 -281 reply
15/18scsi: Add scsi_vpd_lun_id()drivers/scsi/scsi_lib.c include/scsi/scsi_device.h+141 -01 reply
16/18scsi: export 'wwid' to sysfsdrivers/scsi/scsi_sysfs.c+17 -00 replies
17/18scsi: Add scsi_vpd_tpg_id()drivers/scsi/scsi_lib.c include/scsi/scsi_device.h+49 -00 replies
18/18scsi_dh_alua: use scsi_vpd_tpg_id()drivers/scsi/device_handler/scsi_dh_alua.c+6 -330 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchJohannes ThumshirnChristoph HellwigMartin K. PetersenEwan MilneBart Van Assche
1/18R-b R-b
2/18R-b R-b
3/18R-b R-b R-b R-b
4/18R-b R-b R-b
5/18R-b R-b R-b
6/18R-b R-b R-b
7/18R-b R-b R-b
8/18R-b R-b R-b R-b
9/18R-b R-b R-b
10/18R-b R-b R-b R-b
11/18R-b R-b R-b R-b
12/18R-b R-b R-b
13/18R-b R-b
14/18R-b R-b R-b
15/18R-b R-b R-b
16/18R-b
17/18R-b R-b
18/18R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCHv2 00/18] ALUA device handler update, part 1

Hi all,

here's the first part of my ALUA device handler update. It's mainly bugfixes and minor improvements; the two important things are the addition of VPD parsing functions scsi_vpd_lun_id() and scsi_vpd_tpg_id().
This series has been split off from the original 'Asynchronous ALUA' patchset, as these bits are pretty uncontroversial and have a good chance of being merged reasonably soon.

The second part of the ALUA device handler update will be posted (and, doubtlessly, discussed) once this part is in.

Patchset is relative to 4.5/scsi-queue by mkp.
The entire tree can be found at

kernel.org:/pub/scm/linux/kernel/git/hare/scsi-devel.git branch alua.v7

As usual, comments and reviews are welcome.

Changes to v1:
- Update to 4.5/scsi-queue
- Rename 'device_id' to 'wwid'

Hannes Reinecke (18):
scsi_dh: move 'dh_state' sysfs attribute to generic code
scsi: ignore errors from scsi_dh_add_device()
scsi_dh_alua: Disable ALUA handling for non-disk devices
scsi_dh_alua: Use vpd_pg83 information
scsi_dh_alua: improved logging
scsi_dh_alua: sanitze sense code handling
scsi_dh_alua: use standard logging functions
scsi_dh_alua: return standard SCSI return codes in submit_rtpg
scsi_dh_alua: fixup description of stpg_endio()
scsi: remove scsi_show_sense_hdr()
scsi_dh_alua: use flag for RTPG extended header
scsi_dh_alua: use unaligned access macros
scsi_dh_alua: rework alua_check_tpgs() to return the tpgs mode
scsi_dh_alua: simplify sense code handling
scsi: Add scsi_vpd_lun_id()
scsi: export 'wwid' to sysfs
scsi: Add scsi_vpd_tpg_id()
scsi_dh_alua: use scsi_vpd_tpg_id()

 drivers/scsi/device_handler/scsi_dh_alua.c | 294 ++++++++++-------------------
 drivers/scsi/scsi_dh.c                     |  72 +------
 drivers/scsi/scsi_lib.c                    | 188 ++++++++++++++++++
 drivers/scsi/scsi_priv.h                   |   3 +-
 drivers/scsi/scsi_sysfs.c                  |  82 +++++++-
 include/scsi/scsi_dbg.h                    |   2 -
 include/scsi/scsi_device.h                 |   2 +
 7 files changed, 374 insertions(+), 269 deletions(-)
Signature · 1 line
1.8.5.6