atapi: fix NetBSD boot regression
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | atapi: add byte_count_limit helperhw/ | +13 | 0 replies | |
| 2/2 | atapi: Prioritize unknown cmd error over BCL errorhw/ | +10 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Mark Cave-Ayland |
|---|---|
| Series | T-b |
| 1/2 | |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH 0/2] atapi: fix NetBSD boot regression
Marc noticed that a recent ATAPI permissions fix broke NetBSD 7.0's installer ISO.
The problem is that it's meaningless to check for !(cmd->flags & nondata) if the command isn't supported, since all unsupported commands have _no_ flags. Effectively, all commands default to "Transfer Data" in our model until we classify them otherwise.
This leads to a problem where we reject a zero byte BCL PIO command that transfers no data, simply because we have no properties for the command at all.
Getting an ATA rejection for this command greatly confuses NetBSD.
Correct behavior is to reject the command at the SCSI layer for being unsupported.
________________________________________________________________________________
For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch atapi-bclimit-netbsd
https://github.com/jnsnow/qemu/tree/atapi-bclimit-netbsd
This version is tagged atapi-bclimit-netbsd-v1:
https://github.com/jnsnow/qemu/releases/tag/atapi-bclimit-netbsd-v1
John Snow (2):
atapi: add byte_count_limit helper
atapi: Prioritize unknown cmd error over BCL error
hw/ide/atapi.c | 38 +++++++++++++++++++++++--------------- 1 file changed, 23 insertions(+), 15 deletions(-)
Signature · 1 line
2.4.3