Skip to content

RFC LRC irq handler cleanups

Tvrtko Ursulin intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/i915: Avoid invariant conditionals in lrc interrupt handlerdrivers/gpu/drm/i915/intel_lrc.c drivers/gpu/drm/i915/intel_ringbuffer.h+20 -160 replies
2/5drm/i915: Move LRCA check out of the hot pathdrivers/gpu/drm/i915/intel_lrc.c+7 -20 replies
3/5drm/i915: Cache LRCA in the contextdrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_lrc.c +1 more+24 -230 replies
4/5drm/i915: Grab one forcewake across the whole LRC irq handlerdrivers/gpu/drm/i915/intel_lrc.c+38 -220 replies
5/5drm/i915: Only grab and calculate timestamps when neededdrivers/gpu/drm/i915/i915_gem.c+8 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/5] LRC irq handler cleanups

From: Tvrtko Ursulin <[email protected]>

Some random bits to make the LRC irq handler do fewer branching, locking and VMA lookups per interrupt handled.

I failed to measure a significant gain on a powerful chip but it definitely results in fewer instructions and branches in the hot path. So maybe it would help a lower power chip more.

Possibly makes the first run of gem_exec_nop have less variance eg. branch predictor maybe gets warmed up sooner but I am not completely confident in this interpretation.

Tvrtko Ursulin (5):
drm/i915: Avoid invariant conditionals in lrc interrupt handler drm/i915: Move LRCA check out of the hot path drm/i915: Cache LRCA in the context
drm/i915: Grab one forcewake across the whole LRC irq handler drm/i915: Only grab and calculate timestamps when needed

 drivers/gpu/drm/i915/i915_debugfs.c     |  15 ++--
 drivers/gpu/drm/i915/i915_drv.h         |   1 +
 drivers/gpu/drm/i915/i915_gem.c         |  15 ++--
 drivers/gpu/drm/i915/intel_lrc.c        | 131 +++++++++++++++++++-------------
 drivers/gpu/drm/i915/intel_lrc.h        |   3 +-
 drivers/gpu/drm/i915/intel_ringbuffer.h |   2 +
 6 files changed, 97 insertions(+), 70 deletions(-)
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx