Skip to content

hexdump: update test suite

Andy Shevchenko lkml 2 versions – New

Get series with b4
b4 am 1449622205-25619-1-git-send-email-andriy.shevchenko@linux.intel.com

Versions newest first · linked by author and title

  1. v2 Latest9 patches 0 repliesNew
  2. v17 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- address Rasmus' comments
- add tags

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9test_hexdump: rename to test_hexdumplib/Makefile lib/test_hexdump.c+1 -10 replies
2/9test_hexdump: introduce test_hexdump_prepare_test() helperlib/test_hexdump.c+19 -70 replies
3/9test_hexdump: define FILL_CHAR constantlib/test_hexdump.c+13 -60 replies
4/9test_hexdump: go through all possible lengths of bufferlib/test_hexdump.c+13 -140 replies
5/9test_hexdump: replace magic numbers by their meaninglib/test_hexdump.c+13 -40 replies
6/9test_hexdump: switch to memcmp()lib/test_hexdump.c+3 -30 replies
7/9test_hexdump: check all bytes in real bufferlib/test_hexdump.c+17 -210 replies
8/9test_hexdump: test all possible group sizes for overflowlib/test_hexdump.c+18 -30 replies
9/9test_hexdump: print statistics at the endlib/test_hexdump.c+23 -30 replies

Reviews trailers per patch

3 of 9 patches have a Reviewed-by or Acked-by.

PatchRasmus Villemoes
1/9A-b
2/9A-b
3/9
4/9
5/9
6/9
7/9
8/9
9/9A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] hexdump: update test suite

The test suite currently doesn't cover many corner cases when hex_dump_to_buffer() runs into overflow. Refactor and amend test suite to cover most of the cases.

Andrew, please, update entire series in your pool.

Changelog v2:
- address Rasmus' comments
- add tags

Andy Shevchenko (9):
test_hexdump: rename to test_hexdump
test_hexdump: introduce test_hexdump_prepare_test() helper
test_hexdump: define FILL_CHAR constant
test_hexdump: go through all possible lengths of buffer
test_hexdump: replace magic numbers by their meaning
test_hexdump: switch to memcmp()
test_hexdump: check all bytes in real buffer
test_hexdump: test all possible group sizes for overflow
test_hexdump: print statistics at the end

 lib/Makefile                           |   2 +-
 lib/{test-hexdump.c => test_hexdump.c} | 146 +++++++++++++++++++++++----------
 2 files changed, 103 insertions(+), 45 deletions(-)
 rename lib/{test-hexdump.c => test_hexdump.c} (52%)
Signature · 1 line
2.6.2