hexdump: update test suite
Get series with b4
b4 am 1449622205-25619-1-git-send-email-andriy.shevchenko@linux.intel.comVersions newest first · linked by author and title
- v2 Latest9 patches 0 repliesNew
- v17 patches 15 repliesSuperseded
Changes in v2 from the cover letter
- address Rasmus' comments
- add tags
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | test_hexdump: rename to test_hexdumplib/ lib/ | +1 | 0 replies | |
| 2/9 | test_hexdump: introduce test_hexdump_prepare_test() helperlib/ | +19 | 0 replies | |
| 3/9 | test_hexdump: define FILL_CHAR constantlib/ | +13 | 0 replies | |
| 4/9 | test_hexdump: go through all possible lengths of bufferlib/ | +13 | 0 replies | |
| 5/9 | test_hexdump: replace magic numbers by their meaninglib/ | +13 | 0 replies | |
| 6/9 | test_hexdump: switch to memcmp()lib/ | +3 | 0 replies | |
| 7/9 | test_hexdump: check all bytes in real bufferlib/ | +17 | 0 replies | |
| 8/9 | test_hexdump: test all possible group sizes for overflowlib/ | +18 | 0 replies | |
| 9/9 | test_hexdump: print statistics at the endlib/ | +23 | 0 replies |
Reviews trailers per patch
3 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Rasmus Villemoes |
|---|---|
| 1/9 | A-b |
| 2/9 | A-b |
| 3/9 | |
| 4/9 | |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | |
| 9/9 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/9] hexdump: update test suite
The test suite currently doesn't cover many corner cases when hex_dump_to_buffer() runs into overflow. Refactor and amend test suite to cover most of the cases.
Andrew, please, update entire series in your pool.
Changelog v2:
- address Rasmus' comments
- add tags
Andy Shevchenko (9):
test_hexdump: rename to test_hexdump
test_hexdump: introduce test_hexdump_prepare_test() helper
test_hexdump: define FILL_CHAR constant
test_hexdump: go through all possible lengths of buffer
test_hexdump: replace magic numbers by their meaning
test_hexdump: switch to memcmp()
test_hexdump: check all bytes in real buffer
test_hexdump: test all possible group sizes for overflow
test_hexdump: print statistics at the end
lib/Makefile | 2 +-
lib/{test-hexdump.c => test_hexdump.c} | 146 +++++++++++++++++++++++----------
2 files changed, 103 insertions(+), 45 deletions(-)
rename lib/{test-hexdump.c => test_hexdump.c} (52%)Signature · 1 line
2.6.2