Skip to content

Minor cleanups when parsing the "iommu" option

Bandan Das qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v12 patches 2 repliesSuperseded

Changes in v3 from the cover letter

error_report does not need a \n!

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2q35: Check propery to determine if iommu is sethw/core/machine.c hw/pci-host/q35.c include/hw/boards.h+1 -71 reply
2/2i440fx: print an error message if user tries to enable iommuhw/pci-host/piix.c+5 -03 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchEric BlakeMarkus Armbruster
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/2] Minor cleanups when parsing the "iommu" option

Small cleanup changes. The first removes the helper function by directly checking the property and the second adds a error message if user tries to use "-machine iommu=on" with i440fx.

v3:
error_report does not need a \n!

v2:
2/2: use error_report for the warning message

Bandan Das (2):
q35: Check propery to determine if iommu is set
i440fx: print an error message if user tries to enable iommu

 hw/core/machine.c   | 5 -----
 hw/pci-host/piix.c  | 5 +++++
 hw/pci-host/q35.c   | 2 +-
 include/hw/boards.h | 1 -
 4 files changed, 6 insertions(+), 7 deletions(-)
Signature · 1 line
2.5.0