Skip to content

Convert VNC server to QIOChannel

Daniel P. Berrange qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ui: convert VNC server to use QIOChannelSocketui/vnc-auth-sasl.c ui/vnc-auth-vencrypt.c ui/vnc-jobs.c +4 more+433 -3260 replies
2/3ui: convert VNC server to use QIOChannelTLSui/vnc-auth-vencrypt.c ui/vnc-ws.c ui/vnc.c +1 more+73 -2020 replies
3/3ui: convert VNC server to use QIOChannelWebsockui/vnc-ws.c ui/vnc-ws.h ui/vnc.c +1 more+30 -3920 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGerd Hoffmann
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH v1 0/3] Convert VNC server to QIOChannel

This is an update of patches previously shown in an RFC posting

RFC: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.html

This series depends on the previously posted series:

"[PATCH v3 0/9] Introduce I/O channels framework"

This short series converts the VNC server to use the new QIOChannel framework. This removes all the websocket protocol code from the VNC server and further simplifies the TLS handling in the VNC server

The conversion has been tested against the virt-viewer/ remote-viewer programs in the various TLS modes, and also against the noVNC proxy websockets client with and without TLS support.

Daniel P. Berrange (3):
ui: convert VNC server to use QIOChannelSocket
ui: convert VNC server to use QIOChannelTLS
ui: convert VNC server to use QIOChannelWebsock

 ui/vnc-auth-sasl.c     |  57 ++++-
 ui/vnc-auth-vencrypt.c |  93 +++-----
 ui/vnc-jobs.c          |  20 +-
 ui/vnc-ws.c            | 400 ++++++--------------------------
 ui/vnc-ws.h            |  71 +-----
 ui/vnc.c               | 608 ++++++++++++++++++++++---------------------------
 ui/vnc.h               |  31 ++-
 7 files changed, 448 insertions(+), 832 deletions(-)
Signature · 1 line
2.5.0