hv_netvsc: Eliminate the additional head room
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest17 patches 1 replyIn review
- v217 patches 2 repliesSuperseded
- v110 patches 6 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/17 | hv_netvsc: Resize some of the variables in hv_netvsc_packetdrivers/ | +7 | 0 replies | |
| 2/17 | hv_netvsc: Rearrange the hv_negtvsc_packet to be space efficientdrivers/ | +10 | 0 replies | |
| 3/17 | hv_netvsc: Eliminate the channel field in hv_netvsc_packet structuredrivers/ drivers/ drivers/ +1 more | +35 | 0 replies | |
| 4/17 | hv_netvsc: Eliminate rndis_msg pointer from hv_netvsc_packet structuredrivers/ drivers/ drivers/ +1 more | +13 | 0 replies | |
| 5/17 | hv_netvsc: Eliminatte the data field from struct hv_netvsc_packetdrivers/ drivers/ drivers/ +1 more | +14 | 0 replies | |
| 6/17 | hv_netvsc: Eliminate send_completion from struct hv_netvsc_packetdrivers/ drivers/ drivers/ +1 more | +6 | 0 replies | |
| 7/17 | hv_netvsc: Eliminate send_completion_ctx from struct hv_netvsc_packetdrivers/ drivers/ drivers/ | +1 | 0 replies | |
| 8/17 | hv_netvsc: Don't ask for additional head room in the skbdrivers/ drivers/ include/ | +17 | 0 replies | |
| 9/17 | hv_netvsc: move subchannel existence check to netvsc_select_queue()drivers/ drivers/ drivers/ | +5 | 0 replies | |
| 10/17 | hv_netvsc: remove locking in netvsc_send()drivers/ drivers/ | +0 | 0 replies | |
| 11/17 | hv_netvsc: Eliminate page_buf from struct hv_netvsc_packetdrivers/ drivers/ drivers/ +1 more | +35 | 0 replies | |
| 12/17 | hv_netvsc: Eliminate send_completion_tid from struct hv_netvsc_packetdrivers/ drivers/ drivers/ +1 more | +19 | 0 replies | |
| 13/17 | hv_netvsc: Eliminate is_data_pkt from struct hv_netvsc_packetdrivers/ drivers/ drivers/ +1 more | +8 | 0 replies | |
| 14/17 | hv_netvsc: Eliminate completion_func from struct hv_netvsc_packetdrivers/ drivers/ drivers/ | +0 | 0 replies | |
| 15/17 | hv_netvsc: Eliminate xmit_more from struct hv_netvsc_packetdrivers/ drivers/ drivers/ +1 more | +8 | 0 replies | |
| 16/17 | hv_netvsc: Eliminate status from struct hv_netvsc_packetdrivers/ drivers/ drivers/ +1 more | +13 | 0 replies | |
| 17/17 | hv_netvsc: Eliminate vlan_tci from struct hv_netvsc_packetdrivers/ drivers/ drivers/ | +12 | 0 replies |
Reviews trailers per patch
9 of 17 patches have a Reviewed-by or Acked-by.
| Patch | Haiyang Zhang |
|---|---|
| 1/17 | R-b |
| 2/17 | R-b |
| 3/17 | R-b |
| 4/17 | R-b |
| 5/17 | R-b |
| 6/17 | R-b |
| 7/17 | R-b |
| 8/17 | R-b |
| 9/17 | |
| 10/17 | |
| 11/17 | R-b |
| 12/17 | |
| 13/17 | |
| 14/17 | |
| 15/17 | |
| 16/17 | |
| 17/17 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next V3 00/17] hv_netvsc: Eliminate the additional head room
In an attempt to avoid having to allocate memory on the send path, the netvsc driver was requesting additional head room so that both rndis header and the netvsc packet (the state that had to persist) could be placed in the skb. Since the amount of head room requested was exceeding the default head room as set in LL_MAX_HEADER, we were forcing a reallocation of skb.
With this patch-set, I have reduced the size of the netvsc packet to less than 20 bytes and with this reduction we don't need to ask for any additional headroom. We place the rndis header in the skb head room and we place the netvsc packet in control buffer area in the skb.
V2: - Addressed review comments:
- Eliminated more fields from netvsc packet structure.
V3: - Fixed a typo in patch: hv_netvsc: Don't ask for additional head room in the skb.
K. Y. Srinivasan (15):
hv_netvsc: Resize some of the variables in hv_netvsc_packet
hv_netvsc: Rearrange the hv_negtvsc_packet to be space efficient
hv_netvsc: Eliminate the channel field in hv_netvsc_packet structure
hv_netvsc: Eliminate rndis_msg pointer from hv_netvsc_packet
structure
hv_netvsc: Eliminatte the data field from struct hv_netvsc_packet
hv_netvsc: Eliminate send_completion from struct hv_netvsc_packet
hv_netvsc: Eliminate send_completion_ctx from struct hv_netvsc_packet
hv_netvsc: Don't ask for additional head room in the skb
hv_netvsc: Eliminate page_buf from struct hv_netvsc_packet
hv_netvsc: Eliminate send_completion_tid from struct hv_netvsc_packet
hv_netvsc: Eliminate is_data_pkt from struct hv_netvsc_packet
hv_netvsc: Eliminate completion_func from struct hv_netvsc_packet
hv_netvsc: Eliminate xmit_more from struct hv_netvsc_packet
hv_netvsc: Eliminate status from struct hv_netvsc_packet
hv_netvsc: Eliminate vlan_tci from struct hv_netvsc_packet
Vitaly Kuznetsov (2):
hv_netvsc: move subchannel existence check to netvsc_select_queue()
hv_netvsc: remove locking in netvsc_send()
drivers/net/hyperv/hyperv_net.h | 48 +++++++---------- drivers/net/hyperv/netvsc.c | 102 ++++++++++++++++++------------------- drivers/net/hyperv/netvsc_drv.c | 93 +++++++++++++--------------------- drivers/net/hyperv/rndis_filter.c | 66 ++++++++++++------------ include/linux/netdevice.h | 4 +- 5 files changed, 138 insertions(+), 175 deletions(-)
Signature · 1 line
1.7.4.1