Skip to content

Fix hfi1_ioctl locking

[email protected] linux-rdma 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest5 of 13 patches 0 repliesNew

Changes in v3 from the cover letter

Split patch 1 (diag.c Correct code style issues) into 7 patches which each fix a specific checkpatch issue.
Series is now 13 patches

5 of 13 patches are in this archive. The cover letter announces 13.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13staging/rdma/hfi1: diag.c use BIT macrosdrivers/staging/rdma/hfi1/diag.c+2 -20 replies
3/13staging/rdma/hfi1: diag.c fix logical continuationsdrivers/staging/rdma/hfi1/diag.c+3 -30 replies
7/13staging/rdma/hfi1: diag.c correct sizeof parameterdrivers/staging/rdma/hfi1/diag.c+1 -10 replies
8/13staging/rdma/hfi1: Fix camel case variablesdrivers/staging/rdma/hfi1/diag.c+12 -120 replies
9/13staging/rdma/hfi1: Return early from hfi1_ioctl parameter errorsdrivers/staging/rdma/hfi1/diag.c+173 -1750 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMike Marciniszyn
SeriesR-b R-b
1/13
3/13
7/13
8/13
9/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/13] Fix hfi1_ioctl locking

From: Ira Weiny <[email protected]>

It was identified that hfi1_ioctl may sleep with a spin lock held.

This was identified publicly here:

http://www.spinics.net/lists/linux-rdma/msg29926.html

As well as by our internal development.

This series cleans up the code and parameter checks, as well as fixing the locking.

---
Changes from v1
Alter switch to just ignore set link state and default to return -ENOTTY Remove patch which introduced an intermediate bug and squash it in the final patch
Series was 7 patches rather than 8

Changes from v2
Split patch 1 (diag.c Correct code style issues) into 7 patches which each fix a specific checkpatch issue.
Series is now 13 patches

Dennis Dalessandro (2):
staging/rdma/hfi1: Reduce snoop locking scope in IOCTL handler. staging/rdma/hfi1: Return immediately on error

Ira Weiny (11):
staging/rdma/hfi1: diag.c use BIT macros staging/rdma/hfi1: diag.c fix alignment staging/rdma/hfi1: diag.c fix logical continuations staging/rdma/hfi1: diag.c fix white space errors staging/rdma/hfi1: diag.c change null comparisons staging/rdma/hfi1: diag.c add missing braces staging/rdma/hfi1: diag.c correct sizeof parameter staging/rdma/hfi1: Fix camel case variables staging/rdma/hfi1: Return early from hfi1_ioctl parameter errors staging/rdma/hfi1: hfi1_ioctl remove setlink state staging/rdma/hfi1: Further clean up hfi1_ioctl parameter checks

 drivers/staging/rdma/hfi1/diag.c | 464 +++++++++++++++++++--------------------
 1 file changed, 220 insertions(+), 244 deletions(-)
Signature · 1 line
1.8.2