Skip to content

perf stat: Change event enable code

Jiri Olsa lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7perf tools: Use event maps directly in perf_evsel__enabletools/perf/builtin-stat.c tools/perf/util/evsel.c tools/perf/util/evsel.h+6 -60 replies
2/7perf tools: Introduce perf_evsel__disable functiontools/perf/util/evsel.c tools/perf/util/evsel.h+11 -00 replies
3/7perf tools: Factor perf_evlist__(enable|disable) functionstools/perf/util/evlist.c+8 -240 replies
4/7perf stat: Use perf_evlist__enable in handle_initial_delaytools/perf/builtin-stat.c+1 -40 replies
5/7perf stat: Create events as disabledtools/perf/builtin-stat.c+19 -60 replies
6/7perf stat: Move enable_on_exec setup under earlier codetools/perf/builtin-stat.c+9 -60 replies
7/7perf tools: Remove perf_evlist__(enable|disable)_event functionstools/perf/arch/x86/util/intel-bts.c tools/perf/arch/x86/util/intel-pt.c tools/perf/tests/keep-tracking.c +3 more+8 -540 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] perf stat: Change event enable code

hi,
while testing ftrace:function event I noticed we create stat counters as enabled (except for enable_on_exec couters).

This way we count also filter setup and other config code which might be crucial for some events.

Posponing the events enable once everything is ready.

The last patch is RFC as I wasn't sure there's some hidden catch about perf_evlist__(enable|disable)_event functions I missed.. Adrian?

thanks,
jirka

---
Jiri Olsa (7):
perf tools: Use event maps directly in perf_evsel__enable perf tools: Introduce perf_evsel__disable function perf tools: Factor perf_evlist__(enable|disable) functions perf stat: Use perf_evlist__enable in handle_initial_delay perf stat: Create events as disabled
perf stat: Move enable_on_exec setup under earlier code perf tools: Remove perf_evlist__(enable|disable)_event functions

 tools/perf/arch/x86/util/intel-bts.c |  4 ++--
 tools/perf/arch/x86/util/intel-pt.c  |  4 ++--
 tools/perf/builtin-stat.c            | 44 +++++++++++++++++++++++++++-----------------
 tools/perf/tests/keep-tracking.c     |  2 +-
 tools/perf/tests/switch-tracking.c   |  6 +++---
 tools/perf/util/evlist.c             | 74 ++++++++------------------------------------------------------------------
 tools/perf/util/evlist.h             |  4 ----
 tools/perf/util/evsel.c              | 15 ++++++++++++++-
 tools/perf/util/evsel.h              |  3 ++-
 9 files changed, 59 insertions(+), 97 deletions(-)