Skip to content

RFC ARC Dwarf unwinder improvements

Vineet Gupta linux-snps-arc lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest17 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17ARC: dw2 unwind: Elide generation of const propagated clonesarch/arc/kernel/Makefile+1 -00 replies
2/17ARC: dw2 unwind: remove unused cruftarch/arc/include/asm/unwind.h arch/arc/kernel/unwind.c+10 -390 replies
3/17ARC: dw2 unwind: Remove handling of for signal framearch/arc/include/asm/unwind.h arch/arc/kernel/unwind.c+2 -120 replies
4/17ARC: dw2 unwind: Remove FP based unwindingarch/arc/include/asm/unwind.h arch/arc/kernel/unwind.c+3 -530 replies
5/17ARC: dw2 unwind: Better printingarch/arc/kernel/unwind.c+45 -780 replies
6/17ARC: dw2 unwind: Don't verify Main FDE Table size everytimearch/arc/kernel/unwind.c+1 -20 replies
7/17ARC: dw2 unwind: Refactor the FDE lookup table (eh_frame_header) codearch/arc/kernel/unwind.c+83 -920 replies
8/17ARC: dw2 unwind: Don't verify FDE lookup table metadataarch/arc/kernel/unwind.c+8 -290 replies
9/17ARC: dw2 unwind: Use striaght forward code to implement binary lookuparch/arc/kernel/unwind.c+17 -230 replies
10/17ARC: dw2 unwind: CIE parsing/validation done only once at startuparch/arc/kernel/unwind.c+153 -1830 replies
11/17ARC: dw2 unwind: Elide REG_INVALID checkarch/arc/kernel/unwind.c+2 -180 replies
12/17ARC: dw2 unwind: Elide a loop if DW_CFA_register not presentarch/arc/kernel/unwind.c+14 -70 replies
13/17ARC: dw2 unwind: Assume all regs to be unsigned longarch/arc/include/asm/unwind.h arch/arc/kernel/unwind.c+6 -710 replies
14/17ARC: dw2 unwind: No need for __get_userarch/arc/kernel/unwind.c+1 -10 replies
15/17ARC: dw2 unwind: Single exit point for instrumentationarch/arc/kernel/unwind.c+19 -120 replies
16/17ARC: dw2 unwind: skip regs not updatedarch/arc/kernel/unwind.c+6 -30 replies
17/17xxx: instrumentarch/arc/kernel/unwind.c+25 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 00/17] ARC Dwarf unwinder improvements

Hi guys,

In light of perf -g stalling (as unwinder was taking ~3million cycles for non existent entries), I've revamped the dwarf unwinder.

There are some optim tweaks and much of it is "De-generalization" for things which we can safely assume on ARC.

Crude Instrumentation shows following improvements per unwinder call:
- Avg time come down from ~4650 cycles to ~2794 cycles (+40%)
- Max time come down 9793 cycles to 5987 cycles

This is on a SMP FPGA config @ 75 MHz

It seems much of time (65%) is taken for binary lookup thru ~12k FDE entries, roughly 13 lookups, each likely a dcache miss.

git://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc # topic-unwinder-rework-4-instrument

-Vineet

Vineet Gupta (17):
ARC: dw2 unwind: Elide generation of const propagated clones
ARC: dw2 unwind: remove unused cruft
ARC: dw2 unwind: Remove handling of for signal frame
ARC: dw2 unwind: Remove FP based unwinding
ARC: dw2 unwind: Better printing
ARC: dw2 unwind: Don't verify Main FDE Table size everytime
ARC: dw2 unwind: Refactor the FDE lookup table (eh_frame_header) code
ARC: dw2 unwind: Don't verify FDE lookup table metadata
ARC: dw2 unwind: Use striaght forward code to implement binary lookup
ARC: dw2 unwind: CIE parsing/validation done only once at startup
ARC: dw2 unwind: Elide REG_INVALID check
ARC: dw2 unwind: Elide a loop if DW_CFA_register not present
ARC: dw2 unwind: Assume all regs to be unsigned long
ARC: dw2 unwind: No need for __get_user
ARC: dw2 unwind: Single exit point for instrumentation
ARC: dw2 unwind: skip regs not updated
xxx: instrument

 arch/arc/include/asm/unwind.h |  47 +--
 arch/arc/kernel/Makefile      |   1 +
 arch/arc/kernel/unwind.c      | 806 ++++++++++++++++--------------------------
 3 files changed, 313 insertions(+), 541 deletions(-)
Signature · 1 line
1.9.1