Fix the problem of SATA devices within SAS enclosures
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | scsi_transport_sas: add is_sas_attached() functiondrivers/ include/ | +25 | 1 reply | |
| 2/3 | scsi_transport_sas: add function to get SAS endpoint addressdrivers/ include/ | +15 | 1 reply | |
| 3/3 | ses: fix discovery of SATA devices in SAS enclosuresdrivers/ | +4 | 3 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Hannes Reinecke |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] Fix the problem of SATA devices within SAS enclosures
A big use of SAS enclosures is actually to hold SATA devices. Right at the moment, the ses enclosure system doesn't recognize SATA devices. The reason for this is that SAS actually makes up an endpoint address for a SATA device since SATA doesn't have an addressing scheme. The problem this causes is that the made up SAS address doesn't match the SATA NAA identifier in VPD page 0x83, so the address for the device the enclosure reports never matches.
We can fix this by using the SAS transport class to give us the actual end point address instead of using the identity VPD page. This ensures SATA devices are always correctly matched at the expense of pulling in all the SAS transport code. Instead of making ses depend on the SAS transport class, I've introduced an is_sas_attached() function that will allow us to compile out the code if the kernel isn't built with SAS. If anyone ever gets around to doing FC enclosures, they should probably be done in the same way.
James
---
James Bottomley (3):
scsi_transport_sas: add is_sas_attached() function
scsi_transport_sas: add function to get SAS endpoint address
ses: fix discovery of SATA devices in SAS enclosures
drivers/scsi/scsi_transport_sas.c | 30 ++++++++++++++++++++++++++++++ drivers/scsi/ses.c | 22 ++++------------------ include/scsi/scsi_transport_sas.h | 10 ++++++++++ 3 files changed, 44 insertions(+), 18 deletions(-)