Skip to content

drivers/dma: drop modular code from non modular drivers

Paul Gortmaker linux-arm-kernel linux-tegra lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drivers/dma: make edma.c explicitly non-modulardrivers/dma/edma.c+6 -310 replies
2/6drivers/dma: make mmp_pdma.c explicitly non-modulardrivers/dma/mmp_pdma.c+4 -170 replies
3/6drivers/dma: make mmp_tdma.c explicitly non-modulardrivers/dma/mmp_tdma.c+3 -190 replies
4/6drivers/dma: make pxa_dma.c explicitly non-modulardrivers/dma/pxa_dma.c+3 -350 replies
5/6drivers/dma: make sh/shdma-*.c explicitly non-modulardrivers/dma/sh/shdma-base.c drivers/dma/sh/shdma-of.c+5 -201 reply
6/6drivers/dma: make tegra20-apb-dma.c explicitly non-modulardrivers/dma/tegra20-apb-dma.c+4 -310 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] drivers/dma: drop modular code from non modular drivers

This series of commits is a slice of a larger project to ensure people don't have dead code for module removal in non-modular drivers. Overall there is roughly 5k lines of dead code in the kernel due to this.

There is a quasi-separate theme, in that some of the drivers were allowing an unbind implicitly since it is enabled by default. But for core DMA infrastructure drivers, this doesn't seem useful -- so we also disable that here which allows us to delete any ".remove" functions from the drivers that would otherwise be called during the (impossible to trigger) module removal.

Since ARM covers these files the best of all architectures, each file was build tested for allmodconfig on ARM, which at the same time confirms that the files are not built with "CC [M]" -- hence genuinely non-modular.

My testing and the larger patch series in general has been done against the latest linux-next tree.

Paul.
---

Cc Alexandre Courbot <[email protected]>
Cc Daniel Mack <[email protected]>
Cc Dan Williams <[email protected]>
Cc Haojian Zhuang <[email protected]>
Cc Laxman Dewangan <[email protected]>
Cc Robert Jarzmik <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Vinod Koul <[email protected]>
Cc dmaengine at vger.kernel.org
Cc linux-arm-kernel at lists.infradead.org
Cc linux-tegra at vger.kernel.org

Paul Gortmaker (6):
drivers/dma: make edma.c explicitly non-modular drivers/dma: make mmp_pdma.c explicitly non-modular drivers/dma: make mmp_tdma.c explicitly non-modular drivers/dma: make pxa_dma.c explicitly non-modular drivers/dma: make sh/shdma-*.c explicitly non-modular drivers/dma: make tegra20-apb-dma.c explicitly non-modular

 drivers/dma/edma.c            | 37 ++++++-------------------------------
 drivers/dma/mmp_pdma.c        | 21 ++++-----------------
 drivers/dma/mmp_tdma.c        | 22 +++-------------------
 drivers/dma/pxa_dma.c         | 38 +++-----------------------------------
 drivers/dma/sh/shdma-base.c   | 14 ++------------
 drivers/dma/sh/shdma-of.c     | 11 +++--------
 drivers/dma/tegra20-apb-dma.c | 35 ++++-------------------------------
 7 files changed, 25 insertions(+), 153 deletions(-)
Signature · 22 lines
2.6.1


Paul Gortmaker (6):
  drivers/dma: make edma.c explicitly non-modular
  drivers/dma: make mmp_pdma.c explicitly non-modular
  drivers/dma: make mmp_tdma.c explicitly non-modular
  drivers/dma: make pxa_dma.c explicitly non-modular
  drivers/dma: make sh/shdma-*.c explicitly non-modular
  drivers/dma: make tegra20-apb-dma.c explicitly non-modular

 drivers/dma/edma.c            | 37 ++++++-------------------------------
 drivers/dma/mmp_pdma.c        | 21 ++++-----------------
 drivers/dma/mmp_tdma.c        | 22 +++-------------------
 drivers/dma/pxa_dma.c         | 38 +++-----------------------------------
 drivers/dma/sh/shdma-base.c   | 14 ++------------
 drivers/dma/sh/shdma-of.c     | 11 +++--------
 drivers/dma/tegra20-apb-dma.c | 35 ++++-------------------------------
 7 files changed, 25 insertions(+), 153 deletions(-)

-- 
2.6.1