Skip to content

leds: avoid module usage in non-modular code

Paul Gortmaker linux-leds lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drivers/leds: make trigger/ledtrig-cpu.c driver explicitly non-modulardrivers/leds/trigger/ledtrig-cpu.c+1 -251 reply
2/3drivers/leds: make trigger/ledtrig-ide-disk.c driver explicitly non-modulardrivers/leds/trigger/ledtrig-ide-disk.c+1 -130 replies
3/3drivers/leds: make leds-syscon.c explicitly non-modulardrivers/leds/leds-syscon.c+3 -150 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchLinus Walleij
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] leds: avoid module usage in non-modular code

This series of commits is a part of a larger project to ensure people don't reference modular support functions in non-modular code. Overall there was roughly 5k lines of dead code in the kernel due to this. So far we've fixed several areas, like tty, x86, net, ... and we continue to work on other areas.

There are several reasons to not use module support for code that can never be built as a module, but the big ones are:

(1) it is easy to accidentally code up unused module_exit and remove code
(2) it can be misleading when reading the source, thinking it can be modular when the Makefile and/or Kconfig prohibit it
(3) it requires the include of the module.h header file which in turn includes nearly everything else.

For the LED subsystem, there are just three commits. Two are basically trivial remapping to the appropriate non-modular counterparts. The third also has a change to block driver unbinding since that doesn't make any sense and it allows us to delete the .remove code. We've already made similar unbind changes like this in drivers/tty.

Patches created on linux-next and build tested for ARM allmodconfig.

Paul.
---

Cc Bryan Wu <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Jacek Anaszewski <[email protected]>
Cc Richard Purdie <[email protected]>

Paul Gortmaker (3):
drivers/leds: make trigger/ledtrig-cpu.c driver explicitly non-modular drivers/leds: make trigger/ledtrig-ide-disk.c driver explicitly non-modular drivers/leds: make leds-syscon.c explicitly non-modular

 drivers/leds/leds-syscon.c              | 18 +++---------------
 drivers/leds/trigger/ledtrig-cpu.c      | 26 +-------------------------
 drivers/leds/trigger/ledtrig-ide-disk.c | 14 +-------------
 3 files changed, 5 insertions(+), 53 deletions(-)
Signature · 1 line
2.6.1