Skip to content

Migration: Small fixes and improvements

Dr. David Alan Gilbert (git) qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 6 repliesIn review
  2. v16 patches 11 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6migration: Export migrate_set_state()include/migration/migration.h migration/migration.c+23 -151 reply
2/6migration: Add state records for migration incominginclude/migration/migration.h migration/migration.c+11 -60 replies
3/6Postcopy: Send events/change state on incoming sidemigration/savevm.c+15 -70 replies
4/6Migration: Emit event at start of passdocs/qmp-events.txt migration/ram.c qapi/event.json+31 -04 replies
5/6Use qemu_get_buffer_in_place for xbzrle datamigration/ram.c+4 -20 replies
6/6multithread decompression: Avoid one copymigration/ram.c+3 -80 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJuan QuintelaDr. David Alan GilbertzhanghailiangLiang LiEric BlakeAmit Shah
SeriesR-b
1/6R-b R-b
2/6R-b
3/6R-b R-b
4/6R-b R-b
5/6R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/6] Migration: Small fixes and improvements

From: "Dr. David Alan Gilbert" <[email protected]>

This is a set of 4 small fixes and improvements I've been collecting during the 2.5 freeze; I've added in a couple of Zhanghailiang's patches that are easier to merge before rather than after.
(Of which one I've added a small fix of my own, see the message)

Jiri was after events from the incoming postcopy side to make it easy for libvirt; I'd forgotten to add them - Zhanghailiang's patches change the way the events get sent on the incoming side.

Jiri also wanted an event on the outgoing side at each pass, which makes it easy for libvirt to trigger the transition to postcopy.

The other two patches avoid a couple of buffer copies on the incoming side; although in both xbzrle and multithread compression it's rare that the destination is the slow path (but one patch is trivial and the other saves code).

Dave

v2
1/6 update text based on Juan's comments
4/6 Document 'pass' component of event, update qmp-events.txt

Dr. David Alan Gilbert (4):
Postcopy: Send events/change state on incoming side
Migration: Emit event at start of pass
Use qemu_get_buffer_in_place for xbzrle data multithread decompression: Avoid one copy

zhanghailiang (2):
migration: Export migrate_set_state()
migration: Add state records for migration incoming

 docs/qmp-events.txt           | 14 ++++++++++++
 include/migration/migration.h |  3 +++
 migration/migration.c         | 52 ++++++++++++++++++++++++++-----------------
 migration/ram.c               | 21 ++++++++---------
 migration/savevm.c            | 22 ++++++++++++------
 qapi/event.json               | 13 +++++++++++
 6 files changed, 87 insertions(+), 38 deletions(-)
Signature · 1 line
2.5.0