Skip to content

Convert builds/, projects/ and projectbuilds/ to ToasterTable

Elliot Smith yocto-toaster 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17toaster: toastergui Use ToasterTable for projects pagebitbake/lib/toaster/toastergui/tables.py bitbake/lib/toaster/toastergui/templates/projects-toastertable.html bitbake/lib/toaster/toastergui/urls.py+265 -30 replies
2/17toaster: Move image file suffix list to modelbitbake/lib/toaster/orm/models.py bitbake/lib/toaster/toastergui/views.py+10 -60 replies
3/17toaster: Check inferred file suffixes against list of known typesbitbake/lib/toaster/orm/models.py bitbake/lib/toaster/toastergui/tables.py bitbake/lib/toaster/toastergui/views.py+75 -410 replies
4/17toaster: toastergui Switch projects/ view to ToasterTablebitbake/lib/toaster/toastergui/urls.py bitbake/lib/toaster/toastergui/views.py+22 -110 replies
5/17toaster: toastergui Use event delegates for hover help elementsbitbake/lib/toaster/toastergui/static/js/libtoaster.js+4 -20 replies
6/17toaster: toastergui Convert all builds page to ToasterTablebitbake/lib/toaster/orm/models.py bitbake/lib/toaster/toastergui/tables.py bitbake/lib/toaster/toastergui/templates/builds-toastertable.html +2 more+407 -350 replies
7/17toaster: toastergui Add QuerysetFilter classbitbake/lib/toaster/toastergui/querysetfilter.py bitbake/lib/toaster/toastergui/tables.py bitbake/lib/toaster/toastergui/widgets.py+65 -830 replies
8/17toaster: toastergui Refactor ToasterTable filteringbitbake/lib/toaster/toastergui/querysetfilter.py bitbake/lib/toaster/toastergui/static/js/table.js bitbake/lib/toaster/toastergui/tablefilter.py +2 more+289 -1180 replies
9/17toaster: toastergui Switch off filter highlights when inactivebitbake/lib/toaster/toastergui/static/js/table.js+7 -10 replies
10/17toaster: toastergui Show recent builds on all builds pagebitbake/lib/toaster/toastergui/tables.py bitbake/lib/toaster/toastergui/templates/builds-toastertable.html bitbake/lib/toaster/toastergui/templates/mrb_section.html+23 -70 replies
11/17toaster: toastergui Implement date range filters for buildsbitbake/lib/toaster/toastergui/querysetfilter.py bitbake/lib/toaster/toastergui/static/js/table.js bitbake/lib/toaster/toastergui/tablefilter.py +3 more+329 -820 replies
12/17toaster: toastergui Implement "today" and "yesterday" filtersbitbake/lib/toaster/toastergui/querysetfilter.py bitbake/lib/toaster/toastergui/static/js/table.js bitbake/lib/toaster/toastergui/tablefilter.py +3 more+211 -840 replies
13/17toaster: toastergui Convert project builds page to ToasterTablebitbake/lib/toaster/toastergui/static/js/projecttopbar.js bitbake/lib/toaster/toastergui/tables.py bitbake/lib/toaster/toastergui/templates/baseprojectpage.html +5 more+223 -370 replies
14/17toaster: tests Fix Django tests for new ToasterTable pagesbitbake/lib/toaster/toastergui/tests.py+170 -850 replies
15/17toaster: toastergui Don't hide all elements with .col classbitbake/lib/toaster/toastergui/static/js/table.js+4 -40 replies
16/17toaster: toastergui Ensure filter_value updatesbitbake/lib/toaster/toastergui/static/js/table.js+18 -140 replies
17/17toaster: toastergui Streamline construction of filter objectsbitbake/lib/toaster/toastergui/querysetfilter.py bitbake/lib/toaster/toastergui/tablefilter.py bitbake/lib/toaster/toastergui/tables.py +1 more+32 -660 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [review-request][PATCH 00/17] Convert builds/, projects/ and projectbuilds/ to ToasterTable

Convert some of the most important Toaster pages to ToasterTable rather than individual templates.

This involved a rewrite of the ToasterTable filter system (see tablefilter.py) to cope with date range filtering for the builds tables.

I also moved a lot of code out of the views into the model, where it seems better placed.

I also fixed a few JS issues which arose while testing, such as filters not de-selecting when there are multiple filters on a table; event handlers being lost when repopulating a table; and incorrect hiding of page elements due to table classes being used for the page title element.

Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8738

Also incidentally fixes https://bugzilla.yoctoproject.org/show_bug.cgi?id=8792,
as this functionality works correctly in ToasterTable.

Changes since 6d35574 (toaster-next) are in
git://git.yoctoproject.org/poky-contrib, elliot/toaster/tables-8738
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/tables-8738

Elliot Smith (17):
toaster: toastergui Use ToasterTable for projects page
toaster: Move image file suffix list to model
toaster: Check inferred file suffixes against list of known types
toaster: toastergui Switch projects/ view to ToasterTable
toaster: toastergui Use event delegates for hover help elements
toaster: toastergui Convert all builds page to ToasterTable
toaster: toastergui Add QuerysetFilter class
toaster: toastergui Refactor ToasterTable filtering
toaster: toastergui Switch off filter highlights when inactive
toaster: toastergui Show recent builds on all builds page
toaster: toastergui Implement date range filters for builds
toaster: toastergui Implement "today" and "yesterday" filters
toaster: toastergui Convert project builds page to ToasterTable
toaster: tests Fix Django tests for new ToasterTable pages
toaster: toastergui Don't hide all elements with .col class
toaster: toastergui Ensure filter_value updates
toaster: toastergui Streamline construction of filter objects

 bitbake/lib/toaster/orm/models.py                  | 109 ++-
 .../lib/toaster/toastergui/static/js/libtoaster.js |   6 +-
 .../toaster/toastergui/static/js/projecttopbar.js  |   9 +
 bitbake/lib/toaster/toastergui/static/js/table.js  | 272 +++++--
 bitbake/lib/toaster/toastergui/tablefilter.py      | 271 +++++++
 bitbake/lib/toaster/toastergui/tables.py           | 826 +++++++++++++++++++--
 .../toastergui/templates/baseprojectpage.html      |   1 +
 .../toastergui/templates/builds-toastertable.html  |  48 ++
 .../toaster/toastergui/templates/mrb_section.html  |   4 +-
 .../templates/projectbuilds-toastertable.html      |  56 ++
 .../templates/projects-toastertable.html           |  36 +
 .../toaster/toastergui/templates/toastertable.html |   7 +-
 bitbake/lib/toaster/toastergui/tests.py            | 255 ++++---
 bitbake/lib/toaster/toastergui/urls.py             |  14 +-
 bitbake/lib/toaster/toastergui/views.py            |  79 +-
 bitbake/lib/toaster/toastergui/widgets.py          |  94 ++-
 16 files changed, 1781 insertions(+), 306 deletions(-)
 create mode 100644 bitbake/lib/toaster/toastergui/tablefilter.py
 create mode 100644 bitbake/lib/toaster/toastergui/templates/builds-toastertable.html
 create mode 100644 bitbake/lib/toaster/toastergui/templates/projectbuilds-toastertable.html
 create mode 100644 bitbake/lib/toaster/toastergui/templates/projects-toastertable.html

--
Elliot Smith
Software Engineer
Intel OTC

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.