Skip to content

drivers/pci: use builtin_platform_driver in renesas

Paul Gortmaker linux-pci linux-sh lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drivers/pci: make host/pcie-rcar.c explicitly non-modulardrivers/pci/host/pcie-rcar.c+4 -72 replies
2/2drivers/pci: make host/pci-rcar-gen2.c explicitly non-modulardrivers/pci/host/pci-rcar-gen2.c+3 -90 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSimon HormanPhil Edworthy
1/2A-b A-b
2/2A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] drivers/pci: use builtin_platform_driver in renesas

These two commits are extracted from what was a larger series[1] of demodularization in PCI host code that was bool Kconfig.

With the other commits, there was some mixed opinions whether we should make it explicitly non-modular or move towards making it functionally working as a tristate in order to reduce the size of built-in code for multi-platform kernels.

However with the renesas changes, there was no ".remove" and no "module_exit" code stripped out ; it is just a straight 1:1 mapping of the modular macros onto what they become in the non-modular case anyway -- meaning the runtime remains unchanged.

Given that, and the several Ack rec'd, it makes sense to at least get these two in and out of my queue while we consider what to do with the other PCI host code drivers that do have some modularity already coded into them.

Build testing was done on pci/next, using an ARCH=arm allmodconfig and then explicitly building the files changed in this series.

Paul.
---

[1] https://lkml.kernel.org/r/[email protected]

Cc Bjorn Helgaas <[email protected]>
Cc Phil Edworthy <[email protected]>
Cc Simon Horman <[email protected]>
Cc Valentine Barshak <[email protected]>

Paul Gortmaker (2):
drivers/pci: make host/pcie-rcar.c explicitly non-modular drivers/pci: make host/pci-rcar-gen2.c explicitly non-modular

 drivers/pci/host/pci-rcar-gen2.c | 12 +++---------
 drivers/pci/host/pcie-rcar.c     | 11 ++++-------
 2 files changed, 7 insertions(+), 16 deletions(-)
Signature · 1 line
2.6.1