Skip to content

watchdog: Do not use 'dev' from watchdog_device in watchdog drivers

Guenter Roeck linux-watchdog lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 2 repliesIn review
  2. v15 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5watchdog: bcm2835_wdt: Drop log message if watchdog is stoppeddrivers/watchdog/bcm2835_wdt.c+0 -10 replies
2/5watchdog: tangox: Print info message using pointer to platform devicedrivers/watchdog/tangox_wdt.c+1 -10 replies
3/5watchdog: gpio: Do not use device pointer from struct watchdog_devicedrivers/watchdog/gpio_wdt.c+2 -10 replies
4/5watchdog: mena21: Do not use device pointer from struct watchdog_devicedrivers/watchdog/mena21_wdt.c+2 -20 replies
5/5watchdog: qcom-wdt: Do not set 'dev' in struct watchdog_devicedrivers/watchdog/qcom-wdt.c+0 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers

The 'dev' variable in watchdog drivers has a different lifetime than the watchdog character device and should therefore not be used by watchdog drivers.

Some of the drivers use the variable to print kernel messages. Those messages are either dropped or changed to use the parent device. One driver sets the variable during initialization to the watchdog driver's parent device, which is wrong and was removed.

v2: Use parent device for dev_XXX messages instead of pr_XXX.