Skip to content

Namespaceify more of the tcp sysctl knobs

Nikolay Borisov lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/29 patches 1 replyIn review
  2. v1 posting 1/29 patches 1 replySuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9ipv4: Namespaceify tcp syn retries sysctl knobinclude/net/netns/ipv4.h include/net/tcp.h net/ipv4/sysctl_net_ipv4.c +3 more+17 -130 replies
2/9ipv4: Namespaceify tcp synack retries sysctl knobinclude/net/netns/ipv4.h include/net/tcp.h net/ipv4/inet_connection_sock.c +3 more+12 -150 replies
3/9ipv4: Namespaceify tcp syncookies sysctl knobinclude/net/netns/ipv4.h include/net/tcp.h net/ipv4/syncookies.c +5 more+21 -220 replies
4/9ipv4: Namespaceify tcp reordering sysctl knobinclude/net/netns/ipv4.h include/net/tcp.h net/ipv4/sysctl_net_ipv4.c +4 more+21 -180 replies
5/9ipv4: Namespaceify tcp_retries1 sysctl knobinclude/net/netns/ipv4.h include/net/tcp.h net/ipv4/sysctl_net_ipv4.c +2 more+14 -130 replies
6/9ipv4: Namespaceify tcp_retries2 sysctl knobinclude/net/netns/ipv4.h include/net/tcp.h net/ipv4/sysctl_net_ipv4.c +3 more+13 -120 replies
7/9ipv4: Namespaceify tcp_orphan_retries sysctl knobinclude/net/netns/ipv4.h include/net/tcp.h net/ipv4/sysctl_net_ipv4.c +2 more+10 -100 replies
8/9ipv4: Namespaceify tcp_fin_timeout sysctl knobinclude/net/netns/ipv4.h include/net/tcp.h net/ipv4/sysctl_net_ipv4.c +2 more+13 -130 replies
9/9ipv4: Namespaceify tcp_notsent_lowat sysctl knobinclude/net/netns/ipv4.h include/net/tcp.h net/ipv4/sysctl_net_ipv4.c +2 more+11 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RESEND PATCH 0/9] Namespaceify more of the tcp sysctl knobs

This patch series continues making more of the tcp-related sysctl knobs be per net-namespace. Most of these apply per socket and have global defaults so should be safe and I don't expect any breakages.

Having those per net-namespace is useful when multiple containers are hosted and it is required to tune the tcp settings for each independently of the host node.

I've split the patches to be per-sysctl but after the review if the outcome is positive I'm happy to either send it in one big blob or just.

Nikolay Borisov (9):
ipv4: Namespaceify tcp syn retries sysctl knob
ipv4: Namespaceify tcp synack retries sysctl knob
ipv4: Namespaceify tcp syncookies sysctl knob
ipv4: Namespaceify tcp reordering sysctl knob
ipv4: Namespaceify tcp_retries1 sysctl knob
ipv4: Namespaceify tcp_retries2 sysctl knob
ipv4: Namespaceify tcp_orphan_retries sysctl knob
ipv4: Namespaceify tcp_fin_timeout sysctl knob
ipv4: Namespaceify tcp_notsent_lowat sysctl knob

 include/net/netns/ipv4.h        |  10 +++
 include/net/tcp.h               |  17 ++---
 net/ipv4/inet_connection_sock.c |   7 +--
 net/ipv4/syncookies.c           |   4 +-
 net/ipv4/sysctl_net_ipv4.c      | 136 ++++++++++++++++++++--------------------
 net/ipv4/tcp.c                  |  12 ++--
 net/ipv4/tcp_input.c            |  22 ++++---
 net/ipv4/tcp_ipv4.c             |  11 +++-
 net/ipv4/tcp_metrics.c          |   3 +-
 net/ipv4/tcp_minisocks.c        |   3 -
 net/ipv4/tcp_output.c           |   6 +-
 net/ipv4/tcp_timer.c            |  23 +++----
 net/ipv6/syncookies.c           |   2 +-
 13 files changed, 130 insertions(+), 126 deletions(-)
Signature · 1 line
2.5.0