Skip to content

cuda: misc fixes and cleanups

Hervé Poussineau qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 3 repliesIn review
  2. v113 patches 31 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13cuda: add a framework to handle commandshw/misc/macio/cuda.c+34 -00 replies
2/13cuda: move unknown commands reject out of switchhw/misc/macio/cuda.c+16 -140 replies
3/13cuda: port AUTOPOLL command to new frameworkhw/misc/macio/cuda.c+25 -150 replies
4/13cuda: port SET_AUTO_RATE command to new frameworkhw/misc/macio/cuda.c hw/ppc/mac.h+31 -60 replies
5/13cuda: port SET_DEVICE_LIST command to new frameworkhw/input/adb.c hw/misc/macio/cuda.c hw/ppc/mac.h +1 more+28 -110 replies
6/13cuda: port POWERDOWN command to new frameworkhw/misc/macio/cuda.c+13 -40 replies
7/13cuda: port RESET_SYSTEM command to new frameworkhw/misc/macio/cuda.c+13 -40 replies
8/13cuda: port FILE_SERVER_FLAG command to new frameworkhw/misc/macio/cuda.c+16 -10 replies
9/13cuda: port SET_POWER_MESSAGES command to new frameworkhw/misc/macio/cuda.c+16 -30 replies
10/13cuda: port GET_TIME command to new frameworkhw/misc/macio/cuda.c+21 -80 replies
11/13cuda: port SET_TIME command to new frameworkhw/misc/macio/cuda.c+18 -60 replies
12/13cuda: remove GET_6805_ADDR commandhw/misc/macio/cuda.c+0 -30 replies
13/13cuda: remove CUDA_GET_SET_IIC/CUDA_COMBINED_FORMAT_IIC commandshw/misc/macio/cuda.c+0 -230 replies

Reviews trailers per patch

7 of 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid GibsonMark Cave-Ayland
SeriesR-b
1/13
2/13
3/13R-b
4/13
5/13
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13R-b
11/13R-b
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/13] cuda: misc fixes and cleanups

Hi,

This patchset cleans up a little bit the Apple CUDA emulation:
- correctly reject commands with wrong parameters
- support changing the frequency of auto-polling
- support changing device list probed in auto-poll
- add logs when using FILE_SERVER_FLAG/SET_POWER_MESSAGE
- remove unused commands (GET/SET_6805_ADDR)
- remove unimplemented GET_SET_IIC/COMBINED_FORMAT_IIC

GET_SET_IIC/COMBINED_FORMAT_IIC commands should be added again once we implement the I2C bus provided by CUDA.

Hervé

Hervé Poussineau (13):
cuda: add a framework to handle commands
cuda: move unknown commands reject out of switch
cuda: port AUTOPOLL command to new framework
cuda: port SET_AUTO_RATE command to new framework
cuda: port SET_DEVICE_LIST command to new framework
cuda: port POWERDOWN command to new framework
cuda: port RESET_SYSTEM command to new framework
cuda: port FILE_SERVER_FLAG command to new framework
cuda: port SET_POWER_MESSAGES command to new framework
cuda: port GET_TIME command to new framework
cuda: port SET_TIME command to new framework
cuda: remove GET_6805_ADDR command
cuda: remove CUDA_GET_SET_IIC/CUDA_COMBINED_FORMAT_IIC commands

 hw/input/adb.c         |  18 ++--
 hw/misc/macio/cuda.c   | 279 ++++++++++++++++++++++++++++++++++++-------------
 hw/ppc/mac.h           |   2 +
 include/hw/input/adb.h |   2 +-
 4 files changed, 217 insertions(+), 84 deletions(-)
Signature · 1 line
2.1.4