Skip to content

Staging: rts5208: Fix coding style

Shaun Ren linux-arm-kernel lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest8 patches 1 replyIn review
  2. v48 patches 1 replySuperseded
  3. v39 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v29 patches4 repliesSuperseded
v12 patches2 repliesSuperseded

Changes in v5 from the cover letter

* Moved a declaration to the beginning of an if branch

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8Staging: rts5208: rtsx_transport.c: Cleanup commentsdrivers/staging/rts5208/rtsx_transport.c+27 -260 replies
2/8Staging: rts5208: rtsx_transport.c: Align to open parenthesisdrivers/staging/rts5208/rtsx_transport.c+41 -281 reply
2/8Staging: rts5208: rtsx_transport.c: Align to open parenthesisdrivers/staging/rts5208/rtsx_transport.c+41 -280 replies
3/8Staging: rts5208: rtsx_transport.c: Remove spaces after castsdrivers/staging/rts5208/rtsx_transport.c+1 -10 replies
4/8Staging: rts5208: rtsx_transport.c: Add spaces around -drivers/staging/rts5208/rtsx_transport.c+2 -20 replies
5/8Staging: rts5208: rtsx_transport.c: Remove extra newlinesdrivers/staging/rts5208/rtsx_transport.c+0 -30 replies
6/8Staging: rts5208: rtsx_transport.c: Fix label naming conventiondrivers/staging/rts5208/rtsx_transport.c+3 -30 replies
7/8Staging: rts5208: rtsx_transport.c: Remove unnecessary parenthesesdrivers/staging/rts5208/rtsx_transport.c+6 -60 replies
8/8Staging: rts5208: rtsx_transport.c: Fix comparisons to NULLdrivers/staging/rts5208/rtsx_transport.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 RESEND 0/8] Staging: rts5208: Fix coding style

This set of patches fixes the coding style issues in rtsx_transport.c.

Changes since v4
* Moved a declaration to the beginning of an if branch

Changes since v3
* Removed the extraneous SCSI comment in the first patch
* Removed the last patch (Staging: rts5208: Add missing dma_mapping_error) as it is already done in change 9a66d05d82db
(Staging: rts5208: fix check for dma mapping error)

Changes since v2
* Incorporated Joshua Clayton's suggestions regarding the block comments

Shaun Ren (8):
Staging: rts5208: rtsx_transport.c: Cleanup comments
Staging: rts5208: rtsx_transport.c: Align to open parenthesis
Staging: rts5208: rtsx_transport.c: Remove spaces after casts
Staging: rts5208: rtsx_transport.c: Add spaces around -
Staging: rts5208: rtsx_transport.c: Remove extra newlines
Staging: rts5208: rtsx_transport.c: Fix label naming convention
Staging: rts5208: rtsx_transport.c: Remove unnecessary parentheses
Staging: rts5208: rtsx_transport.c: Fix comparisons to NULL

 drivers/staging/rts5208/rtsx_transport.c | 153 +++++++++++++++++--------------
 1 file changed, 82 insertions(+), 71 deletions(-)
Signature · 1 line
2.7.1