hw/virtio: fix double use of a virtio flag
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 4 repliesIn review
- v12 patches 6 repliesSuperseded
Changes in v2 from the cover letter
- Addressed Laurent Vivier's comment:
- forgot to remove a flag
- Added teset-by to the first patch
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | hw/virtio: fix double use of a virtio flaghw/ | +1 | 1 reply | |
| 2/2 | hw/virtio: group virtio flags into an enumhw/ | +10 | 2 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Laurent Vivier | Jason Wang |
|---|---|---|
| 1/2 | T-b | A-b |
| 2/2 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH V2 0/2] hw/virtio: fix double use of a virtio flag
To the obvious question of "how did that happen?"
I can say we had an unlucky break.
Both Jason and me worked on a new different virtio feature in the same time, and they were both merged in the same pull request. We both saw BIT 3 as the last used
https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg03041.html
Commits 1811e64c and a6df8adf use the same virtio feature bit 4 for different features.
Fix it by using different bits.
While at it, group all the virtio flags into an enum to avoid that in the feature.
v1 -> v2:
- Addressed Laurent Vivier's comment:
- forgot to remove a flag
- Added teset-by to the first patch
Marcel Apfelbaum (2):
hw/virtio: fix double use of a virtio flag
hw/virtio: group virtio flags into an enum
hw/virtio/virtio-pci.h | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)
Signature · 1 line
2.4.3