Skip to content

tty: n_gsm: Make mux work as a responder station

Andrej Krpic lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8tty: n_gsm: fix formatting errorsdrivers/tty/n_gsm.c+95 -432 replies
2/8tty: n_gsm: fix C/R bit when sending as a responderdrivers/tty/n_gsm.c+2 -20 replies
3/8tty: n_gsm: make mux work as a responder stationdrivers/tty/n_gsm.c+2 -20 replies
4/8tty: n_gsm: send DM response when accessing an invalid channeldrivers/tty/n_gsm.c+1 -10 replies
5/8tty: n_gsm: replace dead code with a meaningful commentdrivers/tty/n_gsm.c+5 -40 replies
6/8tty: n_gsm: add missing length field in control channel commandsdrivers/tty/n_gsm.c+4 -30 replies
7/8tty: n_gsm: properly format Modem Status Command messagedrivers/tty/n_gsm.c+4 -50 replies
8/8tty: n_gsm: Enable reception of frames separated with a single SOF markerdrivers/tty/n_gsm.c+10 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] tty: n_gsm: Make mux work as a responder station

When using n_gsm you have to explicitly set it to work as a initiator station. This led me to believe that it can also work as a responder.

In a use case where I needed responder station mux I came to the conclusion that it actually does not work. Second and third patch fix dealings with frame C/R bit that then enable mux to work as a responder station.

Next patches in the series then fix bugs that were found after two instances of n_gsm connected over null-modem cable were used.

First patch fixes formatting errors, such as space before comma, and most of the warnings reported by the checkpatch script.

Andrej Krpic (8):
tty: n_gsm: fix formatting errors
tty: n_gsm: fix C/R bit when sending as a responder
tty: n_gsm: make mux work as a responder station
tty: n_gsm: send DM response when accessing an invalid channel
tty: n_gsm: replace dead code with a meaningful comment
tty: n_gsm: add missing length field in control channel commands
tty: n_gsm: properly format Modem Status Command message
tty: n_gsm: Enable reception of frames separated with a single SOF
marker

 drivers/tty/n_gsm.c | 191 +++++++++++++++++++++++++++++++++-------------------
 1 file changed, 123 insertions(+), 68 deletions(-)
Signature · 1 line
2.7.0