Skip to content

Return error on invalid pids for procattr funcs.

Daniel Cashman selinux 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 8 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2libselinux: procattr: return error on invalid pid_t input.libselinux/src/procattr.c+5 -21 reply
2/2libselinux: procattr: return einval for <= 0 pid args.libselinux/src/procattr.c+12 -27 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchNick Kralevich
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Return error on invalid pids for procattr funcs.

From: dcashman <[email protected]>

The getprocattrcon functions currently do not do any validation of the supplied pid argument. This argument is nonsensical for negative pid values and is also not specified for an input value of zero. This is an error-prone convention and should be changed. This is evidenced by issues such as the following android bug:

https://code.google.com/p/android/issues/detail?id=200617

dcashman (2):
libselinux: procattr: return error on invalid pid_t input.
libselinux: procattr: return einval for <= 0 pid args.

 libselinux/src/procattr.c | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)
Signature · 1 line
2.7.0.rc3.207.g0ac5344