i2c: designware-platdrv: Some improvments related to PM
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 of 10 patches 0 repliesNew
2 of 10 patches are in this archive. The cover letter announces 10.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 2/10 | i2c: designware-platdrv: Gate clk in error path in ->probe() | +0 | 3 replies | |
| 10/10 | i2c: designware-platdrv: Rework system PM support | +0 | 1 reply |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ulf Hansson |
|---|---|
| Series | R-b |
| 2/10 | |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/10] i2c: designware-platdrv: Some improvments related to PM
Quoted 6 lines · Ulf Hansson
Here's a couple changes for the i2c-designware driver. Most of them a related to
the support for runtime PM and system PM, but there's also a few that improves
some error handling.
Quoted 6 lines
I have tested these on Hisilicon Linaro 96-board (hi6220). I used a couple local
changes to enable the power-key to act as a wakeup in system PM suspend state.
If anyone are interested about those as well, I am happy to share them.
I know Jarkko spent a lot to understand PM flow in this driver.
My overall feelings after brief reading of the series you fixed a particular problem with your device or flow, which might have broken the half of current users. So, I wouldn't take this without Tested-by tags of (almost) all active stakeholders.
Quoted 21 lines
Ulf Hansson (10):
i2c: designware-platdrv: Return error in ->probe() when clk ungate fails
i2c: designware-platdrv: Gate clk in error path in ->probe()
i2c: designware-platdrv: Unconditionally enable runtime PM
i2c: designware-platdrv: Disable autosuspend in error path in ->probe()
i2c: designware-platdrv: Fix clk gating in ->remove()
i2c: designware-platdrv: Update runtime PM last busy mark in ->probe()
i2c: designware-platdrv: Re-init the HW when resuming
i2c: designware-platdrv: Check return value fromclk_prepare_enable()
i2c: designware-platdrv: Simplify code by usingdev_get_drvdata()
i2c: designware-platdrv: Rework system PM supportdrivers/i2c/busses/i2c-designware-platdrv.c | 106 +++++++++++++----
-----------1 file changed, 50 insertions(+), 56 deletions(-)
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy