Skip to content

firmware: add SmPL grammar to avoid issues

Luis R. Rodriguez cocci linux-leds linux-serial linuxppc-dev lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 3 repliesIn review
  2. v35 patches 4 repliesSuperseded
  3. v25 patches 21 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5MAINTAINERS: extend firmware_class maintainer listMAINTAINERS+1 -03 replies
2/5firmware: annotate thou shalt not request fw on init or probeDocumentation/firmware_class/README drivers/base/Kconfig scripts/coccinelle/api/request_firmware-avoid-init-probe-init.cocci+153 -10 replies
3/5firmware: update usermode helper docs and add SmPL reportDocumentation/firmware_class/README scripts/coccinelle/api/request_firmware-usermode.cocci+68 -50 replies
4/5firmware: add usermode helper DECLARE_FW_LOADER_USER() annotationdrivers/firmware/dell_rbu.c drivers/leds/leds-lp55xx-common.c include/linux/firmware.h +1 more+17 -10 replies
5/5firmware: fix fw cache to avoid usermode helper on suspendDocumentation/firmware_class/README drivers/base/firmware_class.c+4 -150 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchMing Lei
1/5A-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] firmware: add SmPL grammar to avoid issues

Greg,

this v4 includes only two further changes since my last respin:

o As noted by Daniel Wagner, this removes the timeout reset for when the firmware cache is used
o Typo fix as noted by Gabriel Paubert

Luis R. Rodriguez (5):
MAINTAINERS: extend firmware_class maintainer list
firmware: annotate thou shalt not request fw on init or probe
firmware: update usermode helper docs and add SmPL report
firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation
firmware: fix fw cache to avoid usermode helper on suspend

 Documentation/firmware_class/README                |  61 +++++++++-
 MAINTAINERS                                        |   1 +
 drivers/base/Kconfig                               |   2 +-
 drivers/base/firmware_class.c                      |  16 +--
 drivers/firmware/dell_rbu.c                        |   1 +
 drivers/leds/leds-lp55xx-common.c                  |   1 +
 include/linux/firmware.h                           |   7 ++
 .../request_firmware-avoid-init-probe-init.cocci   | 130 +++++++++++++++++++++
 .../coccinelle/api/request_firmware-usermode.cocci |  44 +++++++
 9 files changed, 242 insertions(+), 21 deletions(-)
 create mode 100644 scripts/coccinelle/api/request_firmware-avoid-init-probe-init.cocci
 create mode 100644 scripts/coccinelle/api/request_firmware-usermode.cocci
Signature · 1 line
2.9.2

Read the cover letter in its thread