ACPI / scan: Remove useless #ifndef and simplify container driver
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 2 patches 5 repliesIn review
Patches in v1 No applies recorded yet
None of the 2 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Yasuaki Ishimatsu | Yinghai Lu | Toshi Kani |
|---|---|---|---|
| Series | A-b T-b | A-b | R-b T-b A-b A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/2] ACPI / scan: Remove useless #ifndef and simplify container driver
Quoted 9 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
The only useful thing that the ACPI container driver does is to install system notify handlers for all container and module device objects it finds in the namespace. The driver structure,
acpi_container_driver, and the data structures created by its .add() callback are in fact not used by the driver, so remove them entirely.
Quoted 6 lines
It also makes a little sense to build that driver as a module, so make it non-modular and add its initialization to the namespace scanning code.
In addition to that, make the namespace walk callback used for installing the notify handlers more straightforward.
As pointed out by Toshi Kani, the above changes would make acpi_eject_store() fail for containers and it is the only way to eject them currently, so patch [2/2] is an improved version of this (with Toshi's changes folded in).
Patch [1/2] is just a cleanup removing a useless #ifndef from acpi_eject_store().
Thanks,
Rafael
Signature · 2 lines
I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.