Skip to content

Query User Input patches

David Sommerseth openvpn-devel 1 version In review

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v4 Latest4 patches 9 repliesIn review

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Rework the user input interface to make it more modularsrc/openvpn/Makefile.am src/openvpn/console.c src/openvpn/console.h +3 more+420 -2253 replies
1/4Rework the user input interface to make it more modularsrc/openvpn/Makefile.am src/openvpn/console.c src/openvpn/console.h +3 more+423 -2252 replies
2/4Re-implement the systemd support using the new query user APIconfigure.ac src/openvpn/Makefile.am src/openvpn/console.h +1 more+120 -50 replies
2/4Re-implement the systemd support using the new query user APIconfigure.ac src/openvpn/Makefile.am src/openvpn/console.h +1 more+120 -52 replies
3/4autotools: Add support for extracting version information from pkg-config modulesm4/pkg.m4+6 -32 replies
4/4systemd: Do not mask usernames when querying for it via systemd-ask-passwordconfigure.ac src/openvpn/console_systemd.c+8 -04 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [Openvpn-devel] [PATCH v4 0/4] Query User Input patches

Lets see if fourth time is the charm. This patch set reworks the whole interface of quering the user for input. This will be the building block for enabling OpenVPN to gather as much information as possible at the initalization point, as well as providing an API for other more advanced mechanisms to query the user for input in the OS.

Previous attempts can be found here:
<https://sourceforge.net/p/openvpn/mailman/openvpn-devel/thread/1439311312-2682-1-git-send-email-openvpn.list%40topphemmelig.net/#msg34365281>
<https://sourceforge.net/p/openvpn/mailman/openvpn-devel/thread/1430942786-31419-1-git-send-email-openvpn.list%40topphemmelig.net/#msg34089983>
<https://sourceforge.net/p/openvpn/mailman/openvpn-devel/thread/1416138935-12614-1-git-send-email-openvpn.list%40topphemmelig.net/#msg33044439>

David Sommerseth (4):
Rework the user input interface to make it more modular Re-implement the systemd support using the new query user API
autotools: Add support for extracting version information from
pkg-config modules
systemd: Do not mask usernames when querying for it via
systemd-ask-password

 configure.ac                  |   3 +-
 m4/pkg.m4                     |   9 +-
 src/openvpn/Makefile.am       |   2 +-
 src/openvpn/console.c         | 228 +++++-------------------------------
 src/openvpn/console.h         |  89 +++++++++++++-
 src/openvpn/console_builtin.c | 261 ++++++++++++++++++++++++++++++++++++++++++
 src/openvpn/console_systemd.c | 122 ++++++++++++++++++++
 src/openvpn/misc.c            |  58 +++++++---
 src/openvpn/pkcs11.c          |   7 +-
 9 files changed, 550 insertions(+), 229 deletions(-)
 create mode 100644 src/openvpn/console_builtin.c
 create mode 100644 src/openvpn/console_systemd.c
Signature · 1 line
1.8.3.1