Skip to content

Refactor RDMA IOCTL declarations

Leon Romanovsky linux-rdma 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 9 repliesIn review
  2. v26 patches 22 repliesSuperseded
  3. v16 patches 19 repliesSuperseded

Changes in v3 from the cover letter

* Added Jason's Reviewed-by
* Open-ceded ioctl indexes

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6RDMA/core: Commonize RDMA IOCTL declarations locationinclude/uapi/rdma/Kbuild include/uapi/rdma/hfi/hfi1_user.h include/uapi/rdma/ib_user_mad.h +1 more+46 -40 replies
2/6RDMA/core: Move legacy MAD IOCTL declarations to common fileinclude/uapi/rdma/ib_user_mad.h include/uapi/rdma/rdma_user_ioctl.h+11 -100 replies
3/6RDMA/hfi1: Avoid redeclaration errorinclude/uapi/rdma/hfi/Kbuild include/uapi/rdma/hfi/hfi1_ioctl.h include/uapi/rdma/hfi/hfi1_user.h+175 -1190 replies
4/6RDMA/core: Move HFI1 IOCTL declarations to common fileinclude/uapi/rdma/hfi/hfi1_user.h include/uapi/rdma/rdma_user_ioctl.h+54 -552 replies
5/6RDMA/core: Rename RDMA magic numberinclude/uapi/rdma/rdma_user_ioctl.h+18 -170 replies
6/6RDMA/core: Unify style of IOCTL commandsinclude/uapi/rdma/rdma_user_ioctl.h+38 -606 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJason Gunthorpe
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH rdma-next V3 0/6] Refactor RDMA IOCTL declarations

Hi Doug,

This patch set refactors RDMA IOCTL declarations, unifies their location, moves all current IOCTL exporters to one place and renames them to fix the differences in coding style.

IOCTLs commands need to export the size of their data for their transfer which is usually declared as a struct defined in relevant submodule. These structures should be visible at the linkage stage.

There are number of possible solutions to overcome this limitations.

One of the options is to declare anonymous variable which will be visible during the linkage. As a downside, such option won't allow direct use of this header by other parts of code without their specific includes of other logically unrelated submodules.

Another possible option will be to move declarations of that structures to that common header file. Such move will cause to bloat this file with different submodules declarations.

Our decision was to choose direct include of other exported files with declarations of such structures to simplify future usage of this file. There is no change for legacy applications and libraries.

Changes v2->v3:
* Added Jason's Reviewed-by
* Open-ceded ioctl indexes

Changes v0->v2 (v1 was skipped):
* Update commit messages of patch number 3 and 6.

Available in the "topic/ioctl-header" topic branch of this git repo:
git://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git

Or for browsing:
https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/log/?h=topic/ioctl-header

Thanks

Leon Romanovsky (6):
RDMA/core: Commonize RDMA IOCTL declarations location RDMA/core: Move legacy MAD IOCTL declarations to common file RDMA/hfi1: Avoid redeclaration error
RDMA/core: Move HFI1 IOCTL declarations to common file RDMA/core: Rename RDMA magic number
RDMA/core: Unify style of IOCTL commands

 include/uapi/rdma/Kbuild            |   1 +
 include/uapi/rdma/hfi/Kbuild        |   1 +
 include/uapi/rdma/hfi/hfi1_ioctl.h  | 173 +++++++++++++++++++++++++++++++++++
 include/uapi/rdma/hfi/hfi1_user.h   | 175 +-----------------------------------
 include/uapi/rdma/ib_user_mad.h     |  14 +--
 include/uapi/rdma/rdma_user_ioctl.h |  87 ++++++++++++++++++
 6 files changed, 264 insertions(+), 187 deletions(-)
 create mode 100644 include/uapi/rdma/hfi/hfi1_ioctl.h
 create mode 100644 include/uapi/rdma/rdma_user_ioctl.h

--
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html