Skip to content

openvswitch: add 802.1ad support

Eric Garver netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v22 Latest3 patches 4 repliesIn review
  2. v214 patches 9 repliesSuperseded

Changes in v22 from the cover letter

- merge patch 4 into patch 3
- fix checkpatch.pl errors
- Still some 80 char warnings for long string literals
- refresh pointer after pskb_may_pull()
- refactor vlan nlattr parsing to remove some double checks
- introduce ovs_nla_put_vlan()
- move triple VLAN check to after ethertype serialization
- WARN_ON_ONCE() on triple VLAN and unexpected encap values

Patches in v22 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3openvswitch: 802.1ad uapi changes.include/uapi/linux/openvswitch.h+9 -81 reply
2/3vlan: Check for vlan ethernet types for 8021.q or 802.1adinclude/linux/if_vlan.h+23 -101 reply
3/3openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributesnet/openvswitch/actions.c net/openvswitch/flow.c net/openvswitch/flow.h +2 more+282 -1241 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPravin B Shelar
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v22 thread

Cover letter [PATCH net-next v22 0/3] openvswitch: add 802.1ad support

This series adds 802.1ad support to openvswitch. It is a continuation of the work originally started by Thomas F Herbert - hence the large rev number.

The extra VLAN is implemented by using an additional level of the OVS_KEY_ATTR_ENCAP netlink attribute.
In OVS flow speak, this looks like

eth_type(0x88a8),vlan(vid=100),encap(eth_type(0x8100), vlan(vid=200),

                                        encap(eth_type(0x0800), ...))

The userspace counterpart has also seen recent activity on the ovs-dev mailing lists. There are some new 802.1ad OVS tests being added - also on the ovs-dev list. This patch series has been tested using the most recent version of userspace (v3) and tests (v2).

v22 changes:
- merge patch 4 into patch 3
- fix checkpatch.pl errors
- Still some 80 char warnings for long string literals
- refresh pointer after pskb_may_pull()
- refactor vlan nlattr parsing to remove some double checks
- introduce ovs_nla_put_vlan()
- move triple VLAN check to after ethertype serialization
- WARN_ON_ONCE() on triple VLAN and unexpected encap values

v21 changes:
- Fix (and simplify) netlink attribute parsing
- re-add handling of truncated VLAN tags
- fix if/else dangling assignment in {push,pop}_vlan()
- simplify parse_vlan()

Eric Garver (2):
vlan: Check for vlan ethernet types for 8021.q or 802.1ad
openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink
attributes

Thomas F Herbert (1):
openvswitch: 802.1ad uapi changes.

 include/linux/if_vlan.h          |  33 +++--
 include/uapi/linux/openvswitch.h |  17 ++-
 net/openvswitch/actions.c        |  16 +-
 net/openvswitch/flow.c           |  65 +++++---
 net/openvswitch/flow.h           |   8 +-
 net/openvswitch/flow_netlink.c   | 310 ++++++++++++++++++++++++++-------------
 net/openvswitch/vport.c          |   7 +-
 7 files changed, 314 insertions(+), 142 deletions(-)
Signature · 1 line
2.5.5