Skip to content

Remove some unused CONFIG_* variables

Daniel P. Berrange qemu-devel 1 version Applied

Status from this message: Queued for 2.8, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3default-configs: remove CONFIG_PAMdefault-configs/i386-softmmu.mak default-configs/x86_64-softmmu.mak+0 -20 replies
2/3default-configs: removed obsolete CONFIG_ISA_MMIOdefault-configs/arm-softmmu.mak default-configs/ppc-softmmu.mak default-configs/ppc64-softmmu.mak +1 more+0 -40 replies
3/3default-configs: remove CONFIG_PIIX_PCIdefault-configs/i386-softmmu.mak default-configs/x86_64-softmmu.mak+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] Remove some unused CONFIG_* variables

There are a few CONFIG_* variables defined in default-configs/ that are never referenced. These were found using:

 $ for i in `grep -h -E '^CONFIG' default-configs/*  | sed -e 's/=.*//' | sort | uniq`
 do
     echo -n "$i: "
     git grep $i | grep -v default-configs | wc -l
 done | grep  ": 0"
 CONFIG_IPMI_EXTERN: 0
 CONFIG_ISA_MMIO: 0
 CONFIG_PAM: 0
 CONFIG_PIIX_PCI: 0

NB, the IPMI_EXTERN one is special - it should have been used, so I sent a separate patch for that one.

Daniel P. Berrange (3):
default-configs: remove CONFIG_PAM
default-configs: removed obsolete CONFIG_ISA_MMIO
default-configs: remove CONFIG_PIIX_PCI

 default-configs/arm-softmmu.mak     | 1 -
 default-configs/i386-softmmu.mak    | 2 --
 default-configs/ppc-softmmu.mak     | 1 -
 default-configs/ppc64-softmmu.mak   | 1 -
 default-configs/sparc64-softmmu.mak | 1 -
 default-configs/x86_64-softmmu.mak  | 2 --
 6 files changed, 8 deletions(-)
Signature · 1 line
2.7.4