Skip to content

Add basic ACPI support to the Qualcomm Technologies EMAC driver

Timur Tabi linux-arm-kernel netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v12 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: qcom/emac: do not use devm on internal phy pdevdrivers/net/ethernet/qualcomm/emac/emac-sgmii.c drivers/net/ethernet/qualcomm/emac/emac.c+37 -90 replies
2/3net: qcom/emac: use device_get_mac_addressdrivers/net/ethernet/qualcomm/emac/emac.c+4 -60 replies
3/3net: qcom/emac: initial ACPI supportdrivers/net/ethernet/qualcomm/emac/emac-phy.c drivers/net/ethernet/qualcomm/emac/emac-sgmii.c drivers/net/ethernet/qualcomm/emac/emac.c+95 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH 0/3] [v2] Add basic ACPI support to the Qualcomm Technologies EMAC driver

This patch series adds support to the EMAC driver for extracting addresses, interrupts, and some _DSDs (properties) from ACPI. The first two patches clean up the code, and the third patch adds ACPI-specific functionality.

The first patch fixes a bug with handling the platform_device for the internal PHY. This phy is treated as a separate device in both DT and ACPI, but since the platform is not released automatically when the driver unloads, managed functions like devm_ioremap_resource cannot be used.

The second patch replaces of_get_mac_address with its platform-independent equivalent device_get_mac_address.

The third patch parses the ACPI tables to obtain the platform_device for the primary EMAC node ("QCOM8070") and the internal phy node ("QCOM8071").

Timur Tabi (3):
[v2] net: qcom/emac: do not use devm on internal phy pdev [v2] net: qcom/emac: use device_get_mac_address [v2] net: qcom/emac: initial ACPI support

 drivers/net/ethernet/qualcomm/emac/emac-phy.c   |  37 ++++++--
 drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 110 ++++++++++++++++++------
 drivers/net/ethernet/qualcomm/emac/emac.c       |  26 ++++--
 3 files changed, 134 insertions(+), 39 deletions(-)
Signature · 3 lines
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.