Skip to content

Remove debug prints after allocation failure

Leon Romanovsky linux-rdma 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 9 repliesIn review

Changes in v1 from the cover letter

* Patch 17: Return brackets removed by mistake.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17IB/mad: Remove debug prints after allocation failuredrivers/infiniband/core/mad.c+6 -341 reply
2/17IB/core: Remove debug prints after allocation failuredrivers/infiniband/core/agent.c drivers/infiniband/core/device.c drivers/infiniband/core/fmr_pool.c +3 more+11 -300 replies
3/17IB/core: Release allocated memory in cache setup failuredrivers/infiniband/core/cache.c+7 -93 replies
4/17IB/mlx4: Remove debug prints after allocation failuredrivers/infiniband/hw/mlx4/alias_GUID.c drivers/infiniband/hw/mlx4/cm.c drivers/infiniband/hw/mlx4/mad.c +2 more+8 -300 replies
5/17IB/mlx5: Remove debug prints after allocation failuredrivers/infiniband/hw/mlx5/srq.c+0 -20 replies
6/17IB/hfi1: Remove debug prints after allocation failuredrivers/infiniband/hw/hfi1/pio.c+0 -12 replies
7/17IB/cxgb3: Remove debug prints after allocation failuredrivers/infiniband/hw/cxgb3/cxio_dbg.c+8 -120 replies
8/17IB/cxgb4: Remove debug prints after allocation failuredrivers/infiniband/hw/cxgb4/device.c+0 -40 replies
9/17IB/i40iw: Remove debug prints after allocation failuredrivers/infiniband/hw/i40iw/i40iw_cm.c drivers/infiniband/hw/i40iw/i40iw_main.c drivers/infiniband/hw/i40iw/i40iw_verbs.c+2 -60 replies
10/17IB/qib: Remove debug prints after allocation failuredrivers/infiniband/hw/qib/qib_diag.c drivers/infiniband/hw/qib/qib_eeprom.c drivers/infiniband/hw/qib/qib_iba6120.c +3 more+17 -800 replies
11/17IB/nes: Remove debug prints after allocation failuredrivers/infiniband/hw/nes/nes.c drivers/infiniband/hw/nes/nes_cm.c drivers/infiniband/hw/nes/nes_hw.c +2 more+6 -190 replies
12/17IB/mthca: Remove debug prints after allocation failuredrivers/infiniband/hw/mthca/mthca_reset.c+0 -40 replies
13/17IB/usninc: Remove and fix debug prints after allocation failuredrivers/infiniband/hw/usnic/usnic_ib_qp_grp.c drivers/infiniband/hw/usnic/usnic_vnic.c+7 -250 replies
14/17IB/ocrdma: Remove and fix debug prints after allocation failuredrivers/infiniband/hw/ocrdma/ocrdma_hw.c drivers/infiniband/hw/ocrdma/ocrdma_stats.c+3 -60 replies
15/17IB/rxe: Remove and fix debug prints after allocation failuredrivers/infiniband/sw/rxe/rxe_pool.c+0 -10 replies
16/17IB/isert: Remove and fix debug prints after allocation failuredrivers/infiniband/ulp/isert/ib_isert.c+6 -171 reply
17/17IB/ipoib: Remove and fix debug prints after allocation failuredrivers/infiniband/ulp/ipoib/ipoib_cm.c drivers/infiniband/ulp/ipoib/ipoib_ib.c drivers/infiniband/ulp/ipoib/ipoib_main.c+3 -150 replies

Reviews trailers per patch

2 of 17 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSagi GrimbergIra Weiny
SeriesR-b
1/17R-b
2/17
3/17
4/17
5/17
6/17
7/17
8/17
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17A-b
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH rdma-next V1 00/17] Remove debug prints after allocation failure

Hi Doug and all,

This is semantic cleanup of infiniband stack from printks immediately after allocation failure. It doesn't get rid from all printks, but only from the ones which were found by the following grep construction.

➜ linux-rdma git:(topic/clean-alloc-prints) grep -rI "[k|v][m|z|c]alloc(" drivers/infiniband/* -A5 | grep "n\""

The patchset consists from the 16 almost identical patches and from one fix which was discovered during the cleanup work.

The fix is presented in the patch "IB/core: Release allocated memory in cache setup failure"

Available in the "topic/clean-alloc-prints" topic branch of this git repo:
git://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git
Or for browsing:
https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/log/?h=topic/clean-alloc-prints

CC Sagi Grimberg <[email protected]>
CC Ira Weiny <[email protected]>
CC Steve Wise <[email protected]>
CC Bart Van Assche <[email protected]>
CC Faisal Latif <[email protected]>
CC Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/[email protected]>
CC Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>
CC Mike Marciniszyn <[email protected]>
CC Dennis Dalessandro <[email protected]>a
CC Dave Goodell <[email protected]>

Changes v0 -> v1:
* Patch 17: Return brackets removed by mistake.

Leon Romanovsky (17):
IB/mad: Remove debug prints after allocation failure IB/core: Remove debug prints after allocation failure IB/core: Release allocated memory in cache setup failure IB/mlx4: Remove debug prints after allocation failure IB/mlx5: Remove debug prints after allocation failure IB/hfi1: Remove debug prints after allocation failure IB/cxgb3: Remove debug prints after allocation failure IB/cxgb4: Remove debug prints after allocation failure IB/i40iw: Remove debug prints after allocation failure IB/qib: Remove debug prints after allocation failure IB/nes: Remove debug prints after allocation failure IB/mthca: Remove debug prints after allocation failure IB/usninc: Remove and fix debug prints after allocation failure IB/ocrdma: Remove and fix debug prints after allocation failure IB/rxe: Remove and fix debug prints after allocation failure IB/isert: Remove and fix debug prints after allocation failure IB/ipoib: Remove and fix debug prints after allocation failure

 drivers/infiniband/core/agent.c               |  1 -
 drivers/infiniband/core/cache.c               | 16 ++++-----
 drivers/infiniband/core/device.c              |  5 +--
 drivers/infiniband/core/fmr_pool.c            |  1 -
 drivers/infiniband/core/iwpm_msg.c            |  1 -
 drivers/infiniband/core/iwpm_util.c           | 12 +++----
 drivers/infiniband/core/mad.c                 | 40 ++++-------------------
 drivers/infiniband/core/roce_gid_mgmt.c       | 21 ++++--------
 drivers/infiniband/hw/cxgb3/cxio_dbg.c        | 20 +++++-------
 drivers/infiniband/hw/cxgb4/device.c          |  4 ---
 drivers/infiniband/hw/hfi1/pio.c              |  1 -
 drivers/infiniband/hw/i40iw/i40iw_cm.c        |  2 --
 drivers/infiniband/hw/i40iw/i40iw_main.c      |  5 ++-
 drivers/infiniband/hw/i40iw/i40iw_verbs.c     |  1 -
 drivers/infiniband/hw/mlx4/alias_GUID.c       |  4 +--
 drivers/infiniband/hw/mlx4/cm.c               |  4 +--
 drivers/infiniband/hw/mlx4/mad.c              |  9 ++---
 drivers/infiniband/hw/mlx4/main.c             | 16 ++-------
 drivers/infiniband/hw/mlx4/mcg.c              |  5 +--
 drivers/infiniband/hw/mlx5/srq.c              |  2 --
 drivers/infiniband/hw/mthca/mthca_reset.c     |  4 ---
 drivers/infiniband/hw/nes/nes.c               |  1 -
 drivers/infiniband/hw/nes/nes_cm.c            |  4 +--
 drivers/infiniband/hw/nes/nes_hw.c            |  6 ++--
 drivers/infiniband/hw/nes/nes_mgt.c           | 10 ++----
 drivers/infiniband/hw/nes/nes_verbs.c         |  4 ---
 drivers/infiniband/hw/ocrdma/ocrdma_hw.c      |  5 ++-
 drivers/infiniband/hw/ocrdma/ocrdma_stats.c   |  4 +--
 drivers/infiniband/hw/qib/qib_diag.c          |  6 +---
 drivers/infiniband/hw/qib/qib_eeprom.c        |  6 +---
 drivers/infiniband/hw/qib/qib_iba6120.c       |  8 +----
 drivers/infiniband/hw/qib/qib_iba7220.c       |  8 +----
 drivers/infiniband/hw/qib/qib_iba7322.c       | 22 +++----------
 drivers/infiniband/hw/qib/qib_init.c          | 47 +++++----------------------
 drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 10 +-----
 drivers/infiniband/hw/usnic/usnic_vnic.c      | 22 ++++---------
 drivers/infiniband/sw/rxe/rxe_pool.c          |  1 -
 drivers/infiniband/ulp/ipoib/ipoib_cm.c       |  8 +----
 drivers/infiniband/ulp/ipoib/ipoib_ib.c       |  5 +--
 drivers/infiniband/ulp/ipoib/ipoib_main.c     |  5 +--
 drivers/infiniband/ulp/isert/ib_isert.c       | 23 ++++---------
 41 files changed, 84 insertions(+), 295 deletions(-)

--
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html