Skip to content

net: fix phydev reference leaks

Johan Hovold lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 7 repliesIn review
  2. v11 patch 5 repliesSuperseded

Changes in v2 from the cover letter

- use put_device() instead of phy_dev_free() to put the references taken in net/dsa (patch 1/4).
- add four new patches fixing similar leaks

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: dsa: fix fixed-link-phy device leaksnet/dsa/dsa.c+4 -10 replies
2/5net: bcmgenet: fix phydev reference leakdrivers/net/ethernet/broadcom/genet/bcmmii.c+3 -10 replies
3/5net: fsl/fman: fix phydev reference leakdrivers/net/ethernet/freescale/fman/fman_memac.c+3 -00 replies
4/5net: fsl/fman: fix fixed-link-phydev reference leakdrivers/net/ethernet/freescale/fman/mac.c+2 -01 reply
5/5net: qcom/emac: fix of_node and phydev leaksdrivers/net/ethernet/qualcomm/emac/emac-phy.c drivers/net/ethernet/qualcomm/emac/emac.c+5 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net v2 0/5] net: fix phydev reference leaks

This series fixes a number of phydev reference leaks (and one of_node leak) due to failure to put the reference taken by of_phy_find_device().

Note that I did not try to fix drivers/net/phy/xilinx_gmii2rgmii.c which still leaks a reference.

Against net but should apply just as fine to net-next.

Thanks,
Johan

v2:
- use put_device() instead of phy_dev_free() to put the references taken in net/dsa (patch 1/4).
- add four new patches fixing similar leaks

Johan Hovold (5):
net: dsa: fix fixed-link-phy device leaks
net: bcmgenet: fix phydev reference leak
net: fsl/fman: fix phydev reference leak
net: fsl/fman: fix fixed-link-phydev reference leak
net: qcom/emac: fix of_node and phydev leaks

 drivers/net/ethernet/broadcom/genet/bcmmii.c     | 4 +++-
 drivers/net/ethernet/freescale/fman/fman_memac.c | 3 +++
 drivers/net/ethernet/freescale/fman/mac.c        | 2 ++
 drivers/net/ethernet/qualcomm/emac/emac-phy.c    | 1 +
 drivers/net/ethernet/qualcomm/emac/emac.c        | 4 ++++
 net/dsa/dsa.c                                    | 5 ++++-
 6 files changed, 17 insertions(+), 2 deletions(-)
Signature · 1 line
2.7.3