eal: Remove most causes of panic on init
Status from this message: Applied, thank you so much for this work.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest14 patches 5 repliesApplied
- v626 patches 7 repliesSuperseded
- v526 patches 5 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 26 patches | 9 replies | Superseded | |
| v3 | 25 patches | 4 replies | Superseded | |
| v2 | 25 patches | 1 reply | Superseded | |
| v1 | 25 patches | 17 replies | Superseded |
Changes in v7 from the cover letter
- Squash a bunch of commits
- Make the corresponding BSD side changes
- refactor the PCI probe failure code to be more explicit in the intent
- Remove most of Bruce's acks (with all the shuffling/changes I think the series should be re-evaluated)
Patches in v7 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | eal: do not panic on cpu detectionlib/ lib/ lib/ | +28 | 0 replies | |
| 2/14 | eal: do not panic when CPU isn't supportedlib/ lib/ lib/ +1 more | +30 | 2 replies | |
| 3/14 | eal: do not panic on hugepage info initlib/ lib/ lib/ | +18 | 0 replies | |
| 4/14 | eal: do not panic if parsing args returns errorlib/ lib/ | +12 | 0 replies | |
| 5/14 | eal: do not panic on memzone initialization failslib/ lib/ | +10 | 0 replies | |
| 6/14 | eal: set errno when exiting for already calledlib/ lib/ | +9 | 0 replies | |
| 7/14 | eal: do not panic on a number of conditionslib/ lib/ lib/ | +43 | 0 replies | |
| 8/14 | eal: do not panic on timer init failurelib/ lib/ | +10 | 0 replies | |
| 9/14 | eal: do not panic on interrupt thread initlib/ lib/ lib/ | +12 | 0 replies | |
| 10/14 | eal: do not error if plugins fail to initlib/ lib/ | +2 | 0 replies | |
| 11/14 | eal: do not panic on PCI failureslib/ lib/ lib/ | +31 | 0 replies | |
| 12/14 | eal: do not panic if vdev init failslib/ lib/ lib/ | +5 | 0 replies | |
| 13/14 | eal: do not panic when bus probe/scan failslib/ lib/ | +20 | 0 replies | |
| 14/14 | rte_eal_init: add info about various error codeslib/ | +26 | 0 replies |
Reviews trailers per patch
1 of 14 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Bruce Richardson |
|---|---|
| Series | A-b |
| 1/14 | |
| 2/14 | |
| 3/14 | |
| 4/14 | |
| 5/14 | |
| 6/14 | |
| 7/14 | |
| 8/14 | |
| 9/14 | |
| 10/14 | |
| 11/14 | |
| 12/14 | |
| 13/14 | |
| 14/14 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 00/14] eal: Remove most causes of panic on init
In many cases, it's enough to simply let the application know that the call to initialize DPDK has failed. A complete halt can then be decided by the application based on error returned (and the app could even attempt a possible re-attempt after some corrective action by the user or application).
Changes ->v2:
- Audited all "RTE_LOG (" calls that were introduced, and converted to "RTE_LOG("
- Added some fprintf(stderr, "") lines to indicate errors before logging is initialized
- Removed assignments to errno.
- Changed patch 14/25 to reflect EFAULT, and document in 25/25
Changes ->v3:
- Checkpatch issues in patches 3 (spelling mistake), 9 (issue with leading spaces), and 19 (braces around single line statement if-condition)
Changes ->v4:
- Error text cleanup.
- Add a new check around rte_bus_scan(), added during the development of this series.
Changes ->v5:
- checkpatch.pl cleanup in patch 02/26
- move rte_errno.h include from patch 15 to patch 02
- remove stdbool.h and use int as return type in patch 06/26
Changes ->v6:
- convert all of the initialization calls to RTE_LOG() to rte_eal_init_alert()
- run through check-git-log and checkpatches
- add Bruce's ack to the series
Changes ->v7:
- Squash a bunch of commits
- Make the corresponding BSD side changes
- refactor the PCI probe failure code to be more explicit in the intent
- Remove most of Bruce's acks (with all the shuffling/changes I think the series should be re-evaluated)
Aaron Conole (14):
eal: do not panic on cpu detection
eal: do not panic when CPU isn't supported
eal: do not panic on hugepage info init
eal: do not panic if parsing args returns error
eal: do not panic on memzone initialization fails
eal: set errno when exiting for already called
eal: do not panic on a number of conditions
eal: do not panic on timer init failure
eal: do not panic on interrupt thread init
eal: do not error if plugins fail to init
eal: do not panic on PCI failures
eal: do not panic if vdev init fails
eal: do not panic when bus probe/scan fails
rte_eal_init: add info about various error codes
lib/librte_eal/bsdapp/eal/eal.c | 117 +++++++++++++----- lib/librte_eal/common/eal_common_cpuflags.c | 13 +- lib/librte_eal/common/eal_common_dev.c | 5 +- lib/librte_eal/common/eal_common_lcore.c | 7 +- lib/librte_eal/common/eal_common_pci.c | 12 +- lib/librte_eal/common/eal_common_tailqs.c | 3 +- .../common/include/generic/rte_cpuflags.h | 9 ++ lib/librte_eal/common/include/rte_eal.h | 27 ++++- lib/librte_eal/linuxapp/eal/eal.c | 131 +++++++++++++++------ lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 9 +- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 5 +- 11 files changed, 256 insertions(+), 82 deletions(-)
Signature · 1 line
2.9.3