Skip to content

eal: Remove most causes of panic on init

Aaron Conole dpdk-dev 7 versions – Applied

Status from this message: Applied, thank you so much for this work.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest14 patches 5 repliesApplied
  2. v626 patches 7 repliesSuperseded
  3. v526 patches 5 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v426 patches9 repliesSuperseded
v325 patches4 repliesSuperseded
v225 patches1 replySuperseded
v125 patches17 repliesSuperseded

Changes in v7 from the cover letter

- Squash a bunch of commits
- Make the corresponding BSD side changes
- refactor the PCI probe failure code to be more explicit in the intent
- Remove most of Bruce's acks (with all the shuffling/changes I think the series should be re-evaluated)

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/14eal: do not panic on cpu detectionlib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/common/eal_common_lcore.c lib/librte_eal/linuxapp/eal/eal.c+28 -70 replies
2/14eal: do not panic when CPU isn't supportedlib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/common/eal_common_cpuflags.c lib/librte_eal/common/include/generic/rte_cpuflags.h +1 more+30 -42 replies
3/14eal: do not panic on hugepage info initlib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/linuxapp/eal/eal.c lib/librte_eal/linuxapp/eal/eal_hugepage_info.c+18 -70 replies
4/14eal: do not panic if parsing args returns errorlib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/linuxapp/eal/eal.c+12 -40 replies
5/14eal: do not panic on memzone initialization failslib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/linuxapp/eal/eal.c+10 -40 replies
6/14eal: set errno when exiting for already calledlib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/linuxapp/eal/eal.c+9 -30 replies
7/14eal: do not panic on a number of conditionslib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/common/eal_common_tailqs.c lib/librte_eal/linuxapp/eal/eal.c+43 -180 replies
8/14eal: do not panic on timer init failurelib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/linuxapp/eal/eal.c+10 -40 replies
9/14eal: do not panic on interrupt thread initlib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/linuxapp/eal/eal.c lib/librte_eal/linuxapp/eal/eal_interrupts.c+12 -50 replies
10/14eal: do not error if plugins fail to initlib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/linuxapp/eal/eal.c+2 -20 replies
11/14eal: do not panic on PCI failureslib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/common/eal_common_pci.c lib/librte_eal/linuxapp/eal/eal.c+31 -110 replies
12/14eal: do not panic if vdev init failslib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/common/eal_common_dev.c lib/librte_eal/linuxapp/eal/eal.c+5 -40 replies
13/14eal: do not panic when bus probe/scan failslib/librte_eal/bsdapp/eal/eal.c lib/librte_eal/linuxapp/eal/eal.c+20 -80 replies
14/14rte_eal_init: add info about various error codeslib/librte_eal/common/include/rte_eal.h+26 -10 replies

Reviews trailers per patch

1 of 14 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBruce Richardson
SeriesA-b
1/14
2/14
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 00/14] eal: Remove most causes of panic on init

In many cases, it's enough to simply let the application know that the call to initialize DPDK has failed. A complete halt can then be decided by the application based on error returned (and the app could even attempt a possible re-attempt after some corrective action by the user or application).

Changes ->v2:
- Audited all "RTE_LOG (" calls that were introduced, and converted to "RTE_LOG("
- Added some fprintf(stderr, "") lines to indicate errors before logging is initialized
- Removed assignments to errno.
- Changed patch 14/25 to reflect EFAULT, and document in 25/25

Changes ->v3:
- Checkpatch issues in patches 3 (spelling mistake), 9 (issue with leading spaces), and 19 (braces around single line statement if-condition)

Changes ->v4:
- Error text cleanup.
- Add a new check around rte_bus_scan(), added during the development of this series.

Changes ->v5:
- checkpatch.pl cleanup in patch 02/26
- move rte_errno.h include from patch 15 to patch 02
- remove stdbool.h and use int as return type in patch 06/26

Changes ->v6:
- convert all of the initialization calls to RTE_LOG() to rte_eal_init_alert()
- run through check-git-log and checkpatches
- add Bruce's ack to the series

Changes ->v7:
- Squash a bunch of commits
- Make the corresponding BSD side changes
- refactor the PCI probe failure code to be more explicit in the intent
- Remove most of Bruce's acks (with all the shuffling/changes I think the series should be re-evaluated)

Aaron Conole (14):
eal: do not panic on cpu detection
eal: do not panic when CPU isn't supported
eal: do not panic on hugepage info init
eal: do not panic if parsing args returns error
eal: do not panic on memzone initialization fails
eal: set errno when exiting for already called
eal: do not panic on a number of conditions
eal: do not panic on timer init failure
eal: do not panic on interrupt thread init
eal: do not error if plugins fail to init
eal: do not panic on PCI failures
eal: do not panic if vdev init fails
eal: do not panic when bus probe/scan fails
rte_eal_init: add info about various error codes

 lib/librte_eal/bsdapp/eal/eal.c                    | 117 +++++++++++++-----
 lib/librte_eal/common/eal_common_cpuflags.c        |  13 +-
 lib/librte_eal/common/eal_common_dev.c             |   5 +-
 lib/librte_eal/common/eal_common_lcore.c           |   7 +-
 lib/librte_eal/common/eal_common_pci.c             |  12 +-
 lib/librte_eal/common/eal_common_tailqs.c          |   3 +-
 .../common/include/generic/rte_cpuflags.h          |   9 ++
 lib/librte_eal/common/include/rte_eal.h            |  27 ++++-
 lib/librte_eal/linuxapp/eal/eal.c                  | 131 +++++++++++++++------
 lib/librte_eal/linuxapp/eal/eal_hugepage_info.c    |   9 +-
 lib/librte_eal/linuxapp/eal/eal_interrupts.c       |   5 +-
 11 files changed, 256 insertions(+), 82 deletions(-)
Signature · 1 line
2.9.3