Skip to content

Flatten simple unions where we still can

Markus Armbruster qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

* PATCH 1+2: Since: added [Eric], commit message tweaked
* PATCH 3: new

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3numa: Flatten simple union NumaOptionsnuma.c qapi-schema.json+12 -20 replies
2/3net: Flatten simple union NetLegacyOptionsnet/net.c qapi-schema.json+33 -220 replies
3/3i386/cpu: net: Flatten simple union GuestPanicInformationTypeqapi-schema.json target/i386/cpu.c vl.c+24 -192 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/3] Flatten simple unions where we still can

Simple unions are simpler than flat unions in the schema, but more complicated in C and on the QMP wire: there's extra indirection in C and extra nesting on the wire, both pointless. They're best avoided in new code.

But we can do more: we can flatten the simple unions that aren't used in QMP.

In the longer run, I'd love to get rid of simple unions entirely, and reduce the notational overhead of flat unions in the schema.

v2:
* PATCH 1+2: Since: added [Eric], commit message tweaked
* PATCH 3: new

Markus Armbruster (3):
numa: Flatten simple union NumaOptions
net: Flatten simple union NetLegacyOptions i386/cpu: net: Flatten simple union GuestPanicInformationType

 net/net.c         | 44 ++++++++++++++++++++++----------------------
 numa.c            |  4 ++--
 qapi-schema.json  | 35 +++++++++++++++++++++++++++++++++--
 target/i386/cpu.c | 17 ++++++-----------
 vl.c              | 12 ++++++------
 5 files changed, 69 insertions(+), 43 deletions(-)
Signature · 1 line
2.7.4