Skip to content

RFC mmc: Add Command Queue support

Adrian Hunter linux-block linux-mmc 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest39 patches 23 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/39mmc: block: Use local var for mqrq_curdrivers/mmc/core/block.c+14 -121 reply
2/39mmc: queue: Share mmc request array between partitionsdrivers/mmc/core/block.c drivers/mmc/core/queue.c drivers/mmc/core/queue.h +1 more+156 -970 replies
3/39mmc: block: Introduce queue semanticsdrivers/mmc/core/block.c drivers/mmc/core/queue.c drivers/mmc/core/queue.h+79 -471 reply
4/39mmc: core: Do not prepare a new request twicedrivers/mmc/core/core.c drivers/mmc/core/mmc_test.c include/linux/mmc/host.h+14 -71 reply
5/39mmc: mmc: Add functions to enable / disable the Command QueueDocumentation/mmc/mmc-dev-attrs.txt drivers/mmc/core/mmc.c drivers/mmc/core/mmc_ops.c +2 more+34 -03 replies
6/39mmc: mmc_test: Disable Command Queue while mmc_test is useddrivers/mmc/core/mmc.c drivers/mmc/core/mmc_test.c include/linux/mmc/card.h+23 -00 replies
7/39mmc: block: Disable Command Queue while RPMB is useddrivers/mmc/core/block.c+38 -80 replies
8/39mmc: core: Export mmc_retune_hold() and mmc_retune_release()drivers/mmc/core/host.c+2 -00 replies
9/39mmc: queue: Add a function to control wake-up on new requestsdrivers/mmc/core/queue.c drivers/mmc/core/queue.h+18 -01 reply
10/39mmc: block: Change mmc_apply_rel_rw() to get block address from the requestdrivers/mmc/core/block.c+1 -11 reply
11/39mmc: block: Factor out data preparationdrivers/mmc/core/block.c+82 -691 reply
12/39mmc: block: Add Software Command Queuingdrivers/mmc/core/block.c drivers/mmc/core/queue.c drivers/mmc/core/queue.h +1 more+544 -31 reply
13/39mmc: mmc: Enable Software Command Queuingdrivers/mmc/core/mmc.c+16 -11 reply
14/39mmc: core: Factor out debug prints from mmc_start_request()drivers/mmc/core/core.c+20 -131 reply
15/39mmc: core: Factor out mrq preparation from mmc_start_request()drivers/mmc/core/core.c+27 -131 reply
16/39mmc: core: Add mmc_retune_hold_now()drivers/mmc/core/host.c drivers/mmc/core/host.h+7 -00 replies
17/39mmc: core: Add members to mmc_request and mmc_data for CQE'sinclude/linux/mmc/core.h include/trace/events/mmc.h+23 -71 reply
18/39mmc: host: Add CQE interfaceinclude/linux/mmc/host.h+24 -00 replies
19/39mmc: core: Turn off CQE before sending commandsdrivers/mmc/core/core.c+6 -01 reply
20/39mmc: core: Add support for handling CQE requestsdrivers/mmc/core/core.c include/linux/mmc/core.h+148 -51 reply
21/39mmc: mmc: Enable CQE'sdrivers/mmc/core/bus.c drivers/mmc/core/mmc.c+23 -11 reply
22/39mmc: block: Prepare CQE datadrivers/mmc/core/block.c+29 -115 replies
23/39mmc: block: Add CQE supportdrivers/mmc/core/block.c drivers/mmc/core/block.h drivers/mmc/core/queue.c +1 more+546 -70 replies
24/39mmc: cqhci: support for command queue enabled hostdrivers/mmc/host/Kconfig drivers/mmc/host/Makefile drivers/mmc/host/cqhci.c +1 more+1390 -00 replies
25/39mmc: sdhci: Improve debug print formatdrivers/mmc/host/sdhci.c+12 -161 reply
26/39mmc: sdhci: Add response register to register dumpdrivers/mmc/host/sdhci.c+7 -00 replies
27/39mmc: sdhci: Improve register dump print formatdrivers/mmc/host/sdhci.c+53 -510 replies
28/39mmc: sdhci: Export sdhci_dumpregsdrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+4 -10 replies
29/39mmc: sdhci: Get rid of 'extern' in header filedrivers/mmc/host/sdhci.h+15 -170 replies
30/39mmc: sdhci: Add sdhci_cleanup_hostdrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+27 -110 replies
31/39mmc: sdhci: Factor out sdhci_set_default_irqsdrivers/mmc/host/sdhci.c+13 -80 replies
32/39mmc: sdhci: Add CQE supportdrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+146 -30 replies
33/39mmc: sdhci-pci: Let devices define how to add the hostdrivers/mmc/host/sdhci-pci-core.c drivers/mmc/host/sdhci-pci.h+5 -10 replies
34/39mmc: sdhci-pci: Do not use suspend/resume callbacks with runtime pmdrivers/mmc/host/sdhci-pci-core.c+0 -120 replies
35/39mmc: sdhci-pci: Conditionally compile pm sleep functionsdrivers/mmc/host/sdhci-pci-core.c drivers/mmc/host/sdhci-pci-o2micro.c drivers/mmc/host/sdhci-pci.h+14 -00 replies
36/39mmc: sdhci-pci: Let suspend/resume callbacks replace default callbacksdrivers/mmc/host/sdhci-pci-core.c drivers/mmc/host/sdhci-pci-o2micro.c drivers/mmc/host/sdhci-pci.h+98 -660 replies
37/39mmc: sdhci-pci: Add runtime suspend/resume callbacksdrivers/mmc/host/sdhci-pci-core.c drivers/mmc/host/sdhci-pci.h+55 -340 replies
38/39mmc: sdhci-pci: Move a function to avoid later forward declarationdrivers/mmc/host/sdhci-pci-core.c+39 -390 replies
39/39mmc: sdhci-pci: Add CQHCI support for Intel GLKdrivers/mmc/host/Kconfig drivers/mmc/host/sdhci-pci-core.c+151 -10 replies

Reviews trailers per patch

13 of 39 patches have a Reviewed-by or Acked-by.

PatchHarjani RiteshLinus Walleij
1/39
2/39
3/39
4/39R-b
5/39
6/39R-b
7/39R-b
8/39R-b
9/39
10/39R-b
11/39R-b
12/39
13/39A-b
14/39R-b
15/39R-b
16/39
17/39A-b
18/39
19/39A-b
20/39A-b
21/39R-b
22/39
23/39
24/39
25/39
26/39
27/39
28/39
29/39
30/39
31/39
32/39
33/39
34/39
35/39
36/39
37/39
38/39
39/39

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC 00/39] mmc: Add Command Queue support

Hi

Here are patches to enable hardware command queue (Command Queue Engine or CQE) and software command queue.

Ritesh Harjani graciously agreed the use of their driver which has been re-named CQHCI to match the JEDEC specification and has some more features added.

The first 13 patches enable software command queue. Earlier versions have been submitted before.

The hardware command queue patches are now functionally complete, enabling all block requests (read/write/discard/flush) as well as re-tuning and recovery.

The patches can also be found here:

http://git.infradead.org/users/ahunter/linux-sdhci.git/shortlog/refs/heads/cqe

Adrian Hunter (38):
mmc: block: Use local var for mqrq_cur
mmc: queue: Share mmc request array between partitions
mmc: block: Introduce queue semantics
mmc: core: Do not prepare a new request twice
mmc: mmc: Add functions to enable / disable the Command Queue
mmc: mmc_test: Disable Command Queue while mmc_test is used
mmc: block: Disable Command Queue while RPMB is used
mmc: core: Export mmc_retune_hold() and mmc_retune_release()
mmc: queue: Add a function to control wake-up on new requests
mmc: block: Change mmc_apply_rel_rw() to get block address from the request
mmc: block: Factor out data preparation
mmc: block: Add Software Command Queuing
mmc: mmc: Enable Software Command Queuing
mmc: core: Factor out debug prints from mmc_start_request()
mmc: core: Factor out mrq preparation from mmc_start_request()
mmc: core: Add mmc_retune_hold_now()
mmc: core: Add members to mmc_request and mmc_data for CQE's
mmc: host: Add CQE interface
mmc: core: Turn off CQE before sending commands
mmc: core: Add support for handling CQE requests
mmc: mmc: Enable CQE's
mmc: block: Prepare CQE data
mmc: block: Add CQE support
mmc: sdhci: Improve debug print format
mmc: sdhci: Add response register to register dump
mmc: sdhci: Improve register dump print format
mmc: sdhci: Export sdhci_dumpregs
mmc: sdhci: Get rid of 'extern' in header file
mmc: sdhci: Add sdhci_cleanup_host
mmc: sdhci: Factor out sdhci_set_default_irqs
mmc: sdhci: Add CQE support
mmc: sdhci-pci: Let devices define how to add the host
mmc: sdhci-pci: Do not use suspend/resume callbacks with runtime pm
mmc: sdhci-pci: Conditionally compile pm sleep functions
mmc: sdhci-pci: Let suspend/resume callbacks replace default callbacks
mmc: sdhci-pci: Add runtime suspend/resume callbacks
mmc: sdhci-pci: Move a function to avoid later forward declaration
mmc: sdhci-pci: Add CQHCI support for Intel GLK

Venkat Gopalakrishnan (1):
mmc: cqhci: support for command queue enabled host

 Documentation/mmc/mmc-dev-attrs.txt  |    1 +
 drivers/mmc/core/block.c             | 1021 ++++++++++++++++++++++++++----
 drivers/mmc/core/block.h             |    7 +
 drivers/mmc/core/bus.c               |    7 +
 drivers/mmc/core/core.c              |  212 ++++++-
 drivers/mmc/core/host.c              |    8 +
 drivers/mmc/core/host.h              |    1 +
 drivers/mmc/core/mmc.c               |   41 +-
 drivers/mmc/core/mmc_ops.c           |   28 +
 drivers/mmc/core/mmc_ops.h           |    2 +
 drivers/mmc/core/mmc_test.c          |   22 +-
 drivers/mmc/core/queue.c             |  630 +++++++++++++++----
 drivers/mmc/core/queue.h             |   68 +-
 drivers/mmc/host/Kconfig             |   14 +
 drivers/mmc/host/Makefile            |    1 +
 drivers/mmc/host/cqhci.c             | 1148 ++++++++++++++++++++++++++++++++++
 drivers/mmc/host/cqhci.h             |  228 +++++++
 drivers/mmc/host/sdhci-pci-core.c    |  499 ++++++++++-----
 drivers/mmc/host/sdhci-pci-o2micro.c |    4 +-
 drivers/mmc/host/sdhci-pci.h         |   11 +
 drivers/mmc/host/sdhci.c             |  324 +++++++---
 drivers/mmc/host/sdhci.h             |   54 +-
 include/linux/mmc/card.h             |    8 +
 include/linux/mmc/core.h             |   20 +-
 include/linux/mmc/host.h             |   25 +
 include/trace/events/mmc.h           |   17 +-
 26 files changed, 3871 insertions(+), 530 deletions(-)
 create mode 100644 drivers/mmc/host/cqhci.c
 create mode 100644 drivers/mmc/host/cqhci.h

Regards
Adrian