Skip to content

x86/purgatory: Fix sparse warning, symbol not declared

Tobin C. Harding lkml 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 0 repliesNew
  2. v32 patches 0 repliesSuperseded
  3. v22 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches5 repliesSuperseded

Changes in v4 from the cover letter

- Put preprocessor directives in correct order.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2x86/purgatory: Fix sparse warning, symbol not declaredarch/x86/purgatory/purgatory.c+5 -50 replies
2/2x86/purgatory: Fix sparse warning, symbol not declaredarch/x86/purgatory/purgatory.c arch/x86/purgatory/purgatory.h arch/x86/purgatory/setup-x86_64.S+15 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] x86/purgatory: Fix sparse warning, symbol not declared

Sparse emits several 'symbol not declared' warnings for various functions and variables.

Add static keyword to functions and variables which have file scope only.

Add header file with funciton declaration. Add preprocessor guard and include header in ASM file. Include header in C file contianing function definition.

Changes since v3:
- Put preprocessor directives in correct order.

Changes since v2:
- Add preprocessor guard.

Changes since v1:
- Add header file.

Tobin C. Harding (2):
x86/purgatory: Fix sparse warning, symbol not declared x86/purgatory: Fix sparse warning, symbol not declared

 arch/x86/purgatory/purgatory.c    | 11 ++++++-----
 arch/x86/purgatory/purgatory.h    | 12 ++++++++++++
 arch/x86/purgatory/setup-x86_64.S |  4 ++--
 3 files changed, 20 insertions(+), 7 deletions(-)
 create mode 100644 arch/x86/purgatory/purgatory.h
Signature · 1 line
2.7.4