RFC Add support for pipeline debug (dpipe)
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest8 patches 13 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | devlink: Support for pipeline debug (dpipe)include/ include/ net/ | +1019 | 4 replies | |
| 2/8 | mlxsw: spectrum: Add support for flow counter allocatordrivers/ drivers/ drivers/ +3 more | +242 | 0 replies | |
| 3/8 | mlxsw: reg: Add counter fields to RITR registerdrivers/ | +54 | 0 replies | |
| 4/8 | mlxsw: spectrum: Add placeholder for dpipedrivers/ drivers/ drivers/ +1 more | +109 | 0 replies | |
| 5/8 | mlxsw: spectrum: Add definition for egress rif tabledrivers/ drivers/ | +87 | 0 replies | |
| 6/8 | mlxsw: reg: Add Router Interface Counter Registerdrivers/ | +124 | 0 replies | |
| 7/8 | mlxsw: spectrum: Support for counters on router interfacesdrivers/ drivers/ drivers/ +1 more | +176 | 0 replies | |
| 8/8 | mlxsw: spectrum: Add Support for erif table entries accessdrivers/ | +166 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [patch net-next RFC 0/8] Add support for pipeline debug (dpipe)
From: Jiri Pirko <[email protected]>
Arkadi says:
While doing the hardware offloading process much of the hardware specifics cannot be presented. An example for such is the routing LPM algorithm which differ in hardware implementation from the kernel software implementation. The only information the user receives is whether specific route is offloaded or not, but he cannot really understand the underlying implementation nor get the specific statistics related to that process.
Another example is ACL offload using TC which is commonly implemented using TCAM memory. Currently there is no capability to gain visibility into the TCAM structure and to debug suboptimal resource allocation.
This patchset introduces capability for exporting the ASICs pipeline abstraction via devlink infrastructure, which should serve as an complementary tool. This infrastructure allows the user to get visibility into the ASIC by modeling it as a set of match/action tables.
The main objects defined:
Table - abstraction for a single pipeline stage. Contains the
available match/actions and counter availability.
Entry - entry in a specific table with specific matches/actions
values and dedicated counter.
Header/field - tuples which describes the tables behavior.
As an example one of the ASIC's L3 blocks will be modeled. The egress rif (router interface) table is the final step in the L3 pipeline processing which does match on the internal rif index which was determined before by the routing logic. The erif table determines whether to forward or drop the packet and updates the corresponding rif L3 statistics.
To expose this internal resources a special metadata header will be introduced that describes the internal information gathered by the ASIC's pipeline and contains the following fields: rif_port_index, forward and drop.
Some internal hardware resources have direct mapping to kernel objects. For example the rif_port_index is mapped to the net-devices ifindex. By providing this mapping the users gains visibility into the offloading process.
Follow-up work will include exporting more L3 tables which will give visibility into the routing process.
First stage is adding support for dpipe in devlink. Next add support in spectrum driver. Finally implement egress router interface (erif) table for spectrum ASIC as an example.
Arkadi Sharshevsky (8):
devlink: Support for pipeline debug (dpipe)
mlxsw: spectrum: Add support for flow counter allocator
mlxsw: reg: Add counter fields to RITR register
mlxsw: spectrum: Add placeholder for dpipe
mlxsw: spectrum: Add definition for egress rif table
mlxsw: reg: Add Router Interface Counter Register
mlxsw: spectrum: Support for counters on router interfaces
mlxsw: spectrum: Add Support for erif table entries access
drivers/net/ethernet/mellanox/mlxsw/Makefile | 3 +- drivers/net/ethernet/mellanox/mlxsw/reg.h | 178 +++++ drivers/net/ethernet/mellanox/mlxsw/resources.h | 2 + drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 163 +++++ drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 21 + drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.c | 182 +++++ drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.h | 56 ++ .../net/ethernet/mellanox/mlxsw/spectrum_dpipe.c | 303 +++++++++ .../net/ethernet/mellanox/mlxsw/spectrum_dpipe.h | 43 ++ include/net/devlink.h | 224 +++++- include/uapi/linux/devlink.h | 50 +- net/core/devlink.c | 747 +++++++++++++++++++++ 12 files changed, 1969 insertions(+), 3 deletions(-) create mode 100644 drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.c create mode 100644 drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.h create mode 100644 drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c create mode 100644 drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.h
Signature · 1 line
2.7.4