New op blocker system, part 1
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest44 patches 18 repliesIn review
- v243 patches 1 replySuperseded
- v154 patches 75 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/44 | block: Add op blocker permission constantsinclude/ | +36 | 0 replies | |
| 2/44 | block: Add Error argument to bdrv_attach_child()block.c block/ include/ | +23 | 0 replies | |
| 3/44 | block: Let callers request permissions when attaching a child nodeblock.c block/ include/ | +78 | 0 replies | |
| 4/44 | block: Involve block drivers in permission grantingblock.c include/ | +263 | 1 reply | |
| 5/44 | block: Default .bdrv_child_perm() for filter driversblock.c include/ | +31 | 1 reply | |
| 6/44 | block: Request child permissions in filter driversblock/ block/ block/ +3 more | +8 | 0 replies | |
| 7/44 | block: Default .bdrv_child_perm() for format driversblock.c include/ | +52 | 1 reply | |
| 8/44 | block: Request child permissions in format driversblock/ block/ block/ +9 more | +12 | 0 replies | |
| 9/44 | vvfat: Implement .bdrv_child_perm()block.c block/ include/ | +24 | 0 replies | |
| 10/44 | block: Require .bdrv_child_perm() with child nodesblock.c | +4 | 0 replies | |
| 11/44 | block: Request real permissions in bdrv_attach_child()block.c | +8 | 1 reply | |
| 12/44 | block: Add permissions to BlockBackendblock/ include/ | +29 | 0 replies | |
| 13/44 | block: Add permissions to blk_new()block.c block/ block/ +15 more | +53 | 0 replies | |
| 14/44 | block: Add error parameter to blk_insert_bs()block.c block/ block/ +11 more | +100 | 0 replies | |
| 15/44 | block: Add BDRV_O_RESIZE for blk_new_open()block/ block/ block/ +8 more | +23 | 1 reply | |
| 16/44 | block: Request real permissions in blk_new_open()block/ | +19 | 0 replies | |
| 17/44 | block: Allow error return in BlockDevOps.change_media_cb()block/ blockdev.c hw/ +5 more | +36 | 0 replies | |
| 18/44 | hw/block: Request permissionshw/ hw/ hw/ +14 more | +142 | 1 reply | |
| 19/44 | hw/block: Introduce share-rw qdev propertyhw/ include/ tests/ | +61 | 0 replies | |
| 20/44 | blockjob: Add permissions to block_job_create()block/ block/ block/ +5 more | +24 | 0 replies | |
| 21/44 | block: Add BdrvChildRole.get_parent_desc()block.c block/ include/ | +36 | 0 replies | |
| 22/44 | block: Include details on permission errors in messageblock.c | +56 | 1 reply | |
| 23/44 | block: Add BdrvChildRole.stay_at_nodeblock.c include/ | +7 | 0 replies | |
| 24/44 | blockjob: Add permissions to block_job_add_bdrv()block/ block/ block/ +3 more | +53 | 0 replies | |
| 25/44 | commit: Use real permissions in commit block jobblock/ | +95 | 1 reply | |
| 26/44 | commit: Use real permissions for HMP 'commit'block/ | +27 | 0 replies | |
| 27/44 | backup: Use real permissions in backup block jobblock/ tests/ | +17 | 0 replies | |
| 28/44 | block: Fix pending requests check in bdrv_append()block.c | +2 | 1 reply | |
| 29/44 | block: BdrvChildRole.attach/detach() callbacksblock.c include/ | +63 | 0 replies | |
| 30/44 | block: Allow backing file links in change_parent_backing_link()block.c | +3 | 0 replies | |
| 31/44 | blockjob: Factor out block_job_remove_all_bdrv()blockjob.c include/ | +22 | 1 reply | |
| 32/44 | mirror: Use real permissions in mirror/active commit block jobblock/ qemu-img.c tests/ +1 more | +190 | 1 reply | |
| 33/44 | stream: Use real permissions in streaming block jobblock/ | +27 | 0 replies | |
| 34/44 | mirror: Add filter-node-name to blockdev-mirrorblock/ blockdev.c include/ +1 more | +30 | 0 replies | |
| 35/44 | commit: Add filter-node-name to block-commitblock/ block/ block/ +4 more | +32 | 1 reply | |
| 36/44 | hmp: Request permissions in qemu-ioblock/ hmp.c include/ +2 more | +61 | 0 replies | |
| 37/44 | migration/block: Use real permissionsmigration/ | +17 | 1 reply | |
| 38/44 | nbd/server: Use real permissions for NBD exportsnbd/ | +9 | 0 replies | |
| 39/44 | tests: Remove FIXME commentstests/ tests/ | +2 | 0 replies | |
| 40/44 | block: Pass BdrvChild to bdrv_aligned_preadv/pwritev and copy-on-readblock/ | +21 | 1 reply | |
| 41/44 | block: Assertions for write permissionsblock/ | +3 | 1 reply | |
| 42/44 | block: Assertions for resize permissionblock.c block/ | +4 | 0 replies | |
| 43/44 | block: Add Error parameter to bdrv_set_backing_hd()block.c block/ block/ +3 more | +47 | 1 reply | |
| 44/44 | block: Add Error parameter to bdrv_append()block.c block/ blockdev.c +2 more | +43 | 1 reply |
Reviews trailers per patch
All 44 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v3 00/44] New op blocker system, part 1
This series is the first part of implementing the new op blocker system whose design was agreed on quite a while ago, but proved a bit tricky to implement in places. There is more work to do to fully replace the old op blocker system, but realistically we don't have that much time until the 2.9 freeze. So let's merge this series to complement the traditional op blockers and plan with a second part for the 2.10 timeframe.
The basic idea is that every user of a block node (including things outside the block layer that go through a BlockBackend, and also other block nodes that hold references to it) has to declare which low-level operations/permissions it needs and which operation it allows other users to perform on the same node. Depending on these declarations, conflicts are avoided by returning an error for attempts to attach a conflicting user to the same node.
After this series, all users request permissions, and hopefully all of the permissions they need. For writes and resize, getting the permission first is actually enforced with assertions. Asserting it for consistent reads is in theory doable, but would mean introducing a request flag that tell us that inconsistent reads are okay - and that in all block drivers to recursively propagate this flag through the backing chain. It might not be worth it.
As stated above, the series doesn't remove the old op blockers yet, though in theory the new op blockers should block everything that needs to be blocked. In practice, the read/write/resize blockers should be okay, but BLK_PERM_GRAPH_MOD isn't to be taken too seriously at the moment. It isn't really applied consistently and doesn't do much useful yet. Making proper use of it is left for the part 2 series.
Kevin Wolf (44):
block: Add op blocker permission constants
block: Add Error argument to bdrv_attach_child()
block: Let callers request permissions when attaching a child node
block: Involve block drivers in permission granting
block: Default .bdrv_child_perm() for filter drivers
block: Request child permissions in filter drivers
block: Default .bdrv_child_perm() for format drivers
block: Request child permissions in format drivers
vvfat: Implement .bdrv_child_perm()
block: Require .bdrv_child_perm() with child nodes
block: Request real permissions in bdrv_attach_child()
block: Add permissions to BlockBackend
block: Add permissions to blk_new()
block: Add error parameter to blk_insert_bs()
block: Add BDRV_O_RESIZE for blk_new_open()
block: Request real permissions in blk_new_open()
block: Allow error return in BlockDevOps.change_media_cb() hw/block: Request permissions
hw/block: Introduce share-rw qdev property
blockjob: Add permissions to block_job_create()
block: Add BdrvChildRole.get_parent_desc()
block: Include details on permission errors in message
block: Add BdrvChildRole.stay_at_node
blockjob: Add permissions to block_job_add_bdrv()
commit: Use real permissions in commit block job
commit: Use real permissions for HMP 'commit'
backup: Use real permissions in backup block job
block: Fix pending requests check in bdrv_append()
block: BdrvChildRole.attach/detach() callbacks
block: Allow backing file links in change_parent_backing_link()
blockjob: Factor out block_job_remove_all_bdrv()
mirror: Use real permissions in mirror/active commit block job
stream: Use real permissions in streaming block job
mirror: Add filter-node-name to blockdev-mirror
commit: Add filter-node-name to block-commit
hmp: Request permissions in qemu-io
migration/block: Use real permissions
nbd/server: Use real permissions for NBD exports
tests: Remove FIXME comments
block: Pass BdrvChild to bdrv_aligned_preadv/pwritev and copy-on-read
block: Assertions for write permissions
block: Assertions for resize permission
block: Add Error parameter to bdrv_set_backing_hd()
block: Add Error parameter to bdrv_append()
block.c | 583 ++++++++++++++++++++++++++++++++++----- block/backup.c | 22 +- block/blkdebug.c | 2 + block/blkreplay.c | 1 + block/blkverify.c | 1 + block/block-backend.c | 116 +++++++- block/bochs.c | 1 + block/cloop.c | 1 + block/commit.c | 176 ++++++++++-- block/crypto.c | 1 + block/dmg.c | 1 + block/io.c | 41 +-- block/mirror.c | 237 ++++++++++++++-- block/parallels.c | 4 +- block/qcow.c | 4 +- block/qcow2.c | 19 +- block/qed.c | 4 +- block/quorum.c | 11 +- block/raw-format.c | 1 + block/replication.c | 3 +- block/sheepdog.c | 2 +- block/stream.c | 47 +++- block/vdi.c | 4 +- block/vhdx.c | 4 +- block/vmdk.c | 7 +- block/vpc.c | 4 +- block/vvfat.c | 24 +- blockdev.c | 74 ++++- blockjob.c | 62 ++++- hmp.c | 33 ++- hw/block/block.c | 24 +- hw/block/fdc.c | 28 +- hw/block/m25p80.c | 8 + hw/block/nand.c | 7 + hw/block/nvme.c | 8 +- hw/block/onenand.c | 7 + hw/block/pflash_cfi01.c | 18 +- hw/block/pflash_cfi02.c | 19 +- hw/block/virtio-blk.c | 8 +- hw/core/qdev-properties-system.c | 9 +- hw/ide/core.c | 2 +- hw/ide/qdev.c | 9 +- hw/nvram/spapr_nvram.c | 8 + hw/scsi/scsi-disk.c | 12 +- hw/sd/sd.c | 8 +- hw/usb/dev-storage.c | 6 +- include/block/block.h | 46 ++- include/block/block_int.h | 126 ++++++++- include/block/blockjob.h | 14 +- include/block/blockjob_int.h | 4 +- include/hw/block/block.h | 8 +- include/qemu-io.h | 1 + include/sysemu/block-backend.h | 9 +- migration/block.c | 21 +- nbd/server.c | 16 +- qapi/block-core.json | 16 +- qemu-img.c | 12 +- qemu-io-cmds.c | 28 ++ tests/qemu-iotests/051.pc.out | 6 +- tests/qemu-iotests/055 | 11 +- tests/qemu-iotests/085.out | 2 +- tests/qemu-iotests/141 | 2 +- tests/qemu-iotests/141.out | 4 +- tests/qemu-iotests/172.out | 53 ++++ tests/test-blockjob-txn.c | 6 +- tests/test-blockjob.c | 10 +- tests/test-throttle.c | 7 +- 67 files changed, 1786 insertions(+), 287 deletions(-)
Signature · 1 line
1.8.3.1