Skip to content

perf annotate: Fixes for line numbers and Introduce source_code

Taeung Song lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4perf annotate: Remove needless regular expression for filename:linenrtools/perf/util/annotate.c+1 -152 replies
2/4perf annotate: Align filename:linenr and more correct summarytools/perf/util/annotate.c+2 -153 replies
3/4perf annotate: Change the method counting line numberstools/perf/util/annotate.c+19 -90 replies
4/4perf annotate: Introduce source_code to collect actual codetools/perf/util/annotate.c tools/perf/util/annotate.h+124 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] perf annotate: Fixes for line numbers and Introduce source_code

Hi, :)

Currently perf-annotate have several problems.

- Wrong line numbers on perf-annotate (both stdio and TUI)
- Wrong sum of overhead(percent) matching source lines
- It's so confusing that the output is mixed with
both source code and assembly code. (related to depending on 'objdump -S')

So fix them regarding wrong line numbers
and Introduce new source_code collecting actual code, not depending on 'objdump -S'.

In near future, I have a plan for new reable annotate view base on source code (per function(sym)) using the 'struct source_code'. :)

I'd appreciate some feedback.

(Current v1 don't consider improvement of performance of annotate and don't make code of annotate more compact so I'll consider them in v2)

Thanks,
Taeung

Taeung Song (4):
perf annotate: Remove needless regular expression for filename:linenr perf annotate: Align filename:linenr and more correct summary perf annotate: Change the method counting line numbers perf annotate: Introduce source_code to collect actual code

 tools/perf/util/annotate.c | 174 +++++++++++++++++++++++++++++++++++----------
 tools/perf/util/annotate.h |   7 ++
 2 files changed, 144 insertions(+), 37 deletions(-)
Signature · 1 line
2.7.4