Skip to content

package/cmake: revert the bump to 3.7

Jörg Krause buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Buildroot] [PATCH 0/4] package/cmake: revert the bump to 3.7

Hi Yann,

Quoted 25 lines · Yann E. MORIN

J?rg, All,

On 2017-02-26 09:44 +0100, J?rg Krause spake thusly:

Quoted 10 lines · Yann E. MORIN
Quoted 5 lines

Hello All!

cmake 3.7 causes serious regressions in some cmake-based packages,
related to how RPATH is handled.

For an explanation what's going wrong please have a look at [1].
[1] http://lists.busybox.net/pipermail/buildroot/2017-February/1835
79.html

Are you sure this is related? The code you point to in this mail should
not be executed in cross-compilation:

????if(NOT CMAKE_CROSSCOMPILING AND EXISTS "/etc/debian_version") ??????set_property(GLOBAL PROPERTY FIND_LIBRARY_USE_LIB32_PATHS FALSE)
??????set_property(GLOBAL PROPERTY FIND_LIBRARY_USE_LIB64_PATHS FALSE)
????endif()

Quoted 4 lines

So, if this code is indeed the culprit, then it eans that CMAKE_CROSSCOMPILING is not set, and that in turn is probably the real
issue.

By default FIND_LIBRARY_USE_LIB32_PATHS is set to TRUE [1], but is set to FALSE if NOT cross-compiling AND building on a Debian host.

Quoted 2 lines

(But I only had one coffee since I woke up, so I may have missed something...)

Me, too :-)

[1] https://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/Platform/Unix
Paths.cmake;h=d6c3d41f3112207ee11b42be18db438103e771f7;hb=896ad251#l97