Skip to content

vsock: cancel connect packets when failing to connect

Peng Tao kvm netdev virtualization 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

v4 changelog from the cover letter

- drop two unnecessary void * cast
- update new callback comment

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4vsock: track pkt owner vsockinclude/linux/virtio_vsock.h net/vmw_vsock/virtio_transport_common.c+9 -04 replies
2/4vhost-vsock: add pkt cancel capabilitydrivers/vhost/vsock.c include/net/af_vsock.h+44 -00 replies
3/4vsock: add pkt cancel capabilitynet/vmw_vsock/virtio_transport.c+42 -00 replies
4/4vsock: cancel packets when failing to connectnet/vmw_vsock/af_vsock.c+14 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchStefan HajnocziJorgen Hansen
1/4R-b
2/4R-b R-b
3/4R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH-v4-RESEND 0/4] vsock: cancel connect packets when failing to connect

Hi David,

These patchsets were sent before and reviewed by Stefan and Jorgen [https://www.spinics.net/lists/kvm/msg142367.html].
If there is any blocker, please do tell and I'll see to it. Thanks!

Currently, if a connect call fails on a signal or timeout (e.g., guest is still in the process of starting up), we'll just return to caller and leave the connect packet queued and they are sent even though the connection is considered a failure, which can confuse applications with unwanted false connect attempt.

The patchset enables vsock (both host and guest) to cancel queued packets when a connect attempt is considered to fail.

v4 changelog:
- drop two unnecessary void * cast
- update new callback comment
v3 changelog:
- define cancel_pkt callback in struct vsock_transport rather than struct virtio_transport
- rename virtio_vsock_pkt->vsk to virtio_vsock_pkt->cancel_token
v2 changelog:
- fix queued_replies counting and resume tx/rx when necessary

Cheers,
Tao

Peng Tao (4):
vsock: track pkt owner vsock
vhost-vsock: add pkt cancel capability
vsock: add pkt cancel capability
vsock: cancel packets when failing to connect

 drivers/vhost/vsock.c                   | 41 ++++++++++++++++++++++++++++++++
 include/linux/virtio_vsock.h            |  2 ++
 include/net/af_vsock.h                  |  3 +++
 net/vmw_vsock/af_vsock.c                | 14 +++++++++++
 net/vmw_vsock/virtio_transport.c        | 42 +++++++++++++++++++++++++++++++++
 net/vmw_vsock/virtio_transport_common.c |  7 ++++++
 6 files changed, 109 insertions(+)
Signature · 1 line
2.7.4