Skip to content

Improve readbility of NVME "wwid" attribute

Martin Wilck linux-nvme 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Improve readbility of NVME "wwid" attribute
Quoted 20 lines · Keith Busch
Quoted 19 lines · Martin Wilck

With the current implementation, the default "fallback" WWID generation
code (if no nguid, euid etc. are defined) for Linux NVME host and target
results in the following WWID format:

nvme.0000-3163653363666438366239656630386200- 4c696e7578000000000000000000000000000000000000000000000000000000000 0000000000000-00000002

This is not only hard to read, it poses real problems for multipath (dm WWIDs are limited to 128 characters), and it's not fully standards
compliant.

With this patch series, the WWID on a Linux host connected to a Linux target
looks like this:

Quoted 5 lines
Quoted 1 line

nvme.0000-d319fc8b2883bfec-4c696e7578-00000001

Just curious for non-hex strings, is there a problem with any utilities
if we use the ASCII for both serial and model? It'd be half as long.

That was my first approach to the issue. But then I realized that the term "WWID" is ususally associated with a hex string.
(https://en.wikipedia.org/wiki/World_Wide_Name), so allowing arbitrary ASCII might violate some people's assumptions of how a WWID should look like. (Not to mention that we don't have a vendor OUI...).

Quoted 9 lines

For example, my device's wwid attribute looks like this today:

nvme.8086-46554d42353235363030304a32383041-
494e54454c2053534450454431443134304741-00000001

But would this cause a problem for anything?

nvme.8086-FUMB5256000J280A-INTEL_SSDPED1D140GA-00000001

I don't know. That's why I took the more conservative approach. I think yours is fine (actually much better for human beings), we just shouldn't call it "wwid".

Martin

Signature · 3 lines
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)