Skip to content

x86: acpi: Few enhancements and improvements

Andy Shevchenko u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 7 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH v1 0/7] x86: acpi: Few enhancements and improvements
Quoted 12 lines · Andy Shevchenko

Patch 1 is a build improvement to have better understanding why DSDT is not compiled.

Patches 2 and 3 add date of U-Boot build as OEM revision to the generated tables.

Patch 4 marks fields in FADT in accordance with latest ACPI spec.

Patches 5 and 6 provides a generic "fill" functions that can be replaced
in specific board / architecture code.

Quoted 5 lines

Patch 7 allows to define HW reduced platforms by avoiding ACPI hardware
communication as required by spec.

The series has been tested on Intel Edison board.

# dmesg | grep -i acpi
[    0.000000] Command line: console=tty1 console=ttyS2,115200n8
rootfstype=ramfs rw ignore_loglevel apic=debug
acpi.debug_layer=0xffff056d acpi.debug_level=0x0000200f
[    0.000000] ACPI: Early table checksum verification disabled
[    0.000000] ACPI: RSDP 0x00000000000E4500 000024 (v02 U-BOOT)
[    0.000000] ACPI: XSDT 0x00000000000E45E0 00003C (v01 U-BOOT U-BOOTBL 
20170721 INTL 00000000)
[    0.000000] ACPI: FACP 0x00000000000E4BA0 0000F4 (v06 U-BOOT U-BOOTBL 
20170721 INTL 00000000)
[    0.000000] ACPI: DSDT 0x00000000000E4780 000317 (v02 U-BOOT U-BOOTBL 
00010000 INTL 20170303)
[    0.000000] ACPI: APIC 0x00000000000E4CA0 000048 (v04 U-BOOT U-BOOTBL 
20170721 INTL 00000000)
[    0.000000] ACPI: MCFG 0x00000000000E4CF0 00003C (v01 U-BOOT U-BOOTBL 
20170721 INTL 00000000)
[    0.000000] ACPI: Local APIC address 0xfee00000
[    0.000000] ACPI: no legacy devices present
[    0.000000] ACPI: Local APIC address 0xfee00000
[    0.000000] ACPI: LAPIC (acpi_id[0x00] lapic_id[0x00] enabled)
[    0.000000] ACPI: LAPIC (acpi_id[0x02] lapic_id[0x02] enabled)
[    0.000000] ACPI: IOAPIC (id[0x02] address[0xfec00000] gsi_base[0])
[    0.000000] Using ACPI (MADT) for SMP configuration information
[    0.000000] Kernel command line: console=tty1 console=ttyS2,115200n8
rootfstype=ramfs rw ignore_loglevel apic=debug
acpi.debug_layer=0xffff056d acpi.debug_level=0x0000200f
[    0.000492] ACPI: Core revision 20170531
[    0.001000] ACPI: 1 ACPI AML tables successfully acquired and loaded
[    0.077715] ACPI FADT declares the system doesn't support PCIe ASPM,
so disable it
[    0.078017] ACPI: bus type PCI registered
[    0.128219] ACPI: Added _OSI(Module Device)
[    0.128361] ACPI: Added _OSI(Processor Device)
[    0.128496] ACPI: Added _OSI(3.0 _SCP Extensions)
[    0.128635] ACPI: Added _OSI(Processor Aggregator Device)
[    0.130366] ACPI: Interpreter enabled
[    0.130541] ACPI: (supports S0)
[    0.130647] ACPI: Using IOAPIC for interrupt routing
[    0.130897] PCI: Using host bridge windows from ACPI; if necessary,
use "pci=nocrs" and report a bug
[    0.155018]       bus-0135 bus_get_status        : Device [ACPI]
status [0000000f]
[    0.158317] ACPI: PCI Root Bridge [PCI0] (domain 0000 [bus 00-ff])
[    0.158776] acpi PNP0A08:00: _OSC: OS supports [ExtendedConfig ASPM
ClockPM Segments MSI]
[    0.159628] acpi PNP0A08:00: _OSC: OS now controls [PCIeHotplug PME
AER PCIeCapability]
[    0.159869] acpi PNP0A08:00: FADT indicates ASPM is unsupported,
using BIOS configuration
[    0.161535] acpi PNP0A08:00: [Firmware Info]: MMCONFIG for domain
0000 [bus 00-00] only partially covers this bridge
[    0.221280] ACPI: bus type USB registered
[    0.304179] pnp: PnP ACPI init
[    0.304830] pnp: PnP ACPI: found 0 devices
Quoted 19 lines

Andy Shevchenko (7):
  Makefile: Don't shadow actual error when compile ASL
  Makefile: Export build date as integer
  x86: acpi: Fill OEM revision
  x86: acpi: Name fields in FADT in accordance with specification
  x86: acpi: Deduplicate acpi_fill_madt() implementation
  x86: acpi: Export acpi_fill_mcfg() with __weak attribute
  x86: acpi: Don't touch hardware on HW reduced platforms

 Makefile                          |  2 ++ arch/x86/cpu/baytrail/acpi.c      | 29 --------------------------- arch/x86/cpu/quark/acpi.c         | 29 --------------------------- arch/x86/include/asm/acpi_table.h |  8 +++++--- arch/x86/lib/acpi_table.c         | 41
++++++++++++++++++++++++++++++++++++---
 scripts/Makefile.lib              |  2 +-

 6 files changed, 46 insertions(+), 65 deletions(-)
Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy

Read the cover letter in its thread