Skip to content

scsi: Fixup blacklist handling

Hannes Reinecke linux-scsi 6 versions – Applied

Status from this message: Applied to 4.15/scsi-queue. Thanks for working on this!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest5 patches 11 repliesApplied
  2. v55 patches 2 repliesSuperseded
  3. v45 patches 5 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches15 repliesSuperseded
v24 patches5 repliesSuperseded
v14 patches6 repliesSuperseded

Changes to v1 from the cover letter

- Implement exact match for vendor string as suggested by Bart
- Straigten out issues pointed out by Alan Stern
- Reshuffle patches

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/5scsi_debug: allow to specify inquiry vendor and modeldrivers/scsi/scsi_debug.c+17 -81 reply
2/5scsi: Export blacklist flags to sysfsdrivers/scsi/Makefile drivers/scsi/scsi_scan.c drivers/scsi/scsi_sysfs.c+46 -05 replies
3/5scsi_devinfo: Reformat blacklist flagsinclude/scsi/scsi_devinfo.h+50 -261 reply
4/5scsi_devinfo: Whitespace fixesdrivers/scsi/scsi_devinfo.c+22 -221 reply
5/5scsi_devinfo: fixup string comparedrivers/scsi/scsi_devinfo.c+13 -101 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchBart van AsscheAlan SternDoug GilbertJohannes Thumshirn
1/5R-b A-b R-b
2/5R-b R-b
3/5R-b R-b
4/5R-b
5/5R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v6 thread

Cover letter [PATCHv6 0/5] scsi: Fixup blacklist handling

Hi all,

the SCSI blacklist handling seems to be rather tricky issue; everytime a fix is included it tends to break other devices. This patchset attempt to simplify the devlist handling yet again, but this time implementing the framework for regression testing, too. A patch adding a regression test to the blktest suite will follow.

As usual, comments and reviews are welcome.

Changes to v1:
- Implement exact match for vendor string as suggested by Bart
- Straigten out issues pointed out by Alan Stern
- Reshuffle patches

Changes to v2:
- Simplify code as indicated by Alan Stern
- Display blacklist flags verbatim
- Reformat blacklist flags definition for better readability

Changes to v3:
- Add reviews from Alan Stern
- Generate blacklist flag definitions
- Include reviews from Martin Petersen

Changes to v4:
- Add reviews from Bart
- Rework blacklist flag string generation

Changes to v5:
- Add bounds checking for sysfs attribute
- Add review from Doug Gilbert

Hannes Reinecke (5):
scsi_debug: allow to specify inquiry vendor and model
scsi: Export blacklist flags to sysfs
scsi_devinfo: Reformat blacklist flags
scsi_devinfo: Whitespace fixes
scsi_devinfo: fixup string compare

 drivers/scsi/Makefile       |  8 +++++
 drivers/scsi/scsi_debug.c   | 25 ++++++++++-----
 drivers/scsi/scsi_devinfo.c | 67 ++++++++++++++++++++-------------------
 drivers/scsi/scsi_scan.c    |  1 +
 drivers/scsi/scsi_sysfs.c   | 37 ++++++++++++++++++++++
 include/scsi/scsi_devinfo.h | 76 +++++++++++++++++++++++++++++----------------
 6 files changed, 148 insertions(+), 66 deletions(-)
Signature · 1 line
1.8.5.6